remove search from the toolbar #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This also allows us to not have a discussion which search engine to use :) #293 |
Closed
samueldr
approved these changes
Mar 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nixos.org is already index in all the search engines and this is what most people use and search now days happens outside the website. This would of-course not be true if our search would be very tightly integrated with nixos.org.
Other websites I checked (kubernets.io, rust-lang.io) out also don't include this kind of search (full text over all sites) and just rely on google to index them.
I do think we "expose" more search over existing packages and nixos options but that would take some time to get there. first step would be to remove this search in the first place.