Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

osu-lazer: Init at 2020.306.0 #82742

Closed
wants to merge 1 commit into from
Closed

osu-lazer: Init at 2020.306.0 #82742

wants to merge 1 commit into from
+643 −0

Conversation

skykanin
Copy link
Contributor

@skykanin skykanin commented Mar 16, 2020 •
edited
Loading

Motivation for this change

Add the osu-lazer rythm game to nixpkgs

Issues that need to be resolved

Since there isn't easy way to package dotnet packages I've been relying on this package heavily for reference, but I'm still having some issues with restoring packages. I'm still not quite sure what file I should be parsing to retrieve the nuget package dependencies for osu.

  • create-deps.sh doesn't properly parse the names of some packages (as a temp fix I've added them manually)
  • running dotnet list osu.sln package > mypackage-restore.log and then ./create-deps.sh mypackage-restore.log > deps.nix creates duplicate nuget package entries in deps.nix
  • nix-build -A osu-lazer complains about missing packages
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Mar 16, 2020
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/dotnet-package-build-access-to-the-path-homeless-shelter-dotnet-is-denied-error/6181/5

@skykanin skykanin marked this pull request as draft April 21, 2020 21:29
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/dotnet-package-build-access-to-the-path-homeless-shelter-dotnet-is-denied-error/6181/7

@dali99
Copy link
Member

dali99 commented Jul 16, 2020

Are you aware of #85021 ?

@skykanin
Copy link
Contributor Author

Are you aware of #85021 ?

I did not, closing in favour of #85021

@skykanin skykanin closed this Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@skykanin @nixos-discourse @dali99