Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.03] python37Packages.fastapi: 0.45.0 -> 0.49.0 #82758

Merged
merged 2 commits into from Mar 21, 2020
Merged

[20.03] python37Packages.fastapi: 0.45.0 -> 0.49.0 #82758

merged 2 commits into from Mar 21, 2020

Conversation

wd15
Copy link
Contributor

@wd15 wd15 commented Mar 16, 2020 •
edited

Motivation for this change

(cherry picked from commit ffebc62 and 5634ef5)

Backport of #81305

ZHF: #80379

Fixing Hydra failure

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@wd15
python37Packages.starlette: 0.13.0 -> 0.12.9
9d99c49 
 - Reverting the version of Starlette as FastAPI can not use anything
   greater than 0.12.12. FastAPI is Starlette's only dependent.

 - Use fetchurl instead of fetchPypi as this is now the preferred
   method. This also makes the tests pass and, thus, the build, which
   was failing.
@wd15
python37Packages.fastapi: 0.45.0 -> 0.49.0
55fee4d 
 - Add peewee to test environment as now required.

 - Remove pyproject.toml patching as no longer required.
@wd15
Copy link
Contributor Author

wd15 commented Mar 16, 2020

Result of nixpkgs-review pr 82758 1

2 packages built:
  • python37Packages.fastapi
  • python37Packages.starlette

JeffLabonte
JeffLabonte approved these changes Mar 18, 2020
View reviewed changes
Copy link
Contributor

@JeffLabonte JeffLabonte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rnhmjoj rnhmjoj merged commit 1674925 into NixOS:release-20.03 Mar 21, 2020
@wd15 wd15 deleted the fastapi-0.49.0 branch April 14, 2021 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeffLabonte JeffLabonte JeffLabonte approved these changes

@FRidh FRidh Awaiting requested review from FRidh FRidh is a code owner

@jonringer jonringer Awaiting requested review from jonringer jonringer is a code owner

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wd15 @JeffLabonte @rnhmjoj