Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unityhub: fix hash #82757

Merged
merged 1 commit into from Mar 23, 2020
Merged

unityhub: fix hash #82757

merged 1 commit into from Mar 23, 2020

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Mar 16, 2020 •
edited

Motivation for this change

noticed this:

hash mismatch in fixed-output derivation '/nix/store/9cqma387r5qxzgb0yp449bkw6ffaiy0n-UnityHub.AppImage':
  wanted: sha256:1rx7ih94ig3pd1yx1d3fpx7zpixq3j5birkpnzkh778qqsdrg0nf
  got:    sha256:05p5kqbwgqyk2aw2lix5dk1ql16aj6iczxrc63a1l0vj8wrha7z4

when reviewing other packages.

Unfortunately they seem to not have distribution methods which have stable URLs

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
[1 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/82757
1 package built:
unityhub

@veprbl
Copy link
Member

veprbl commented Mar 17, 2020

cc @tesq0 @ar1a @PlumpMath

@ar1a
Copy link
Contributor

ar1a commented Mar 17, 2020

#65391 (comment)

one proposed solution to having to do this every time is uploading the appimage to archive.org

Ma27
Ma27 reviewed Mar 17, 2020
View reviewed changes
Copy link
Member

@Ma27 Ma27 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could add an alternative url (so basically using the urls parameter of fetchurl) which points to a web.archive.org link.

EDIT: my mistake, only looked at the code and not the discussion, @ar1a was (12 hours) faster, sorry! :)

@nh2
Copy link
Contributor

nh2 commented Mar 18, 2020

Unfortunately they seem to not have distribution methods which have stable URLs

Has anybody already asked them about providing one?

@jonringer jonringer mentioned this pull request Mar 18, 2020
Closed
10 tasks
@jonringer
Copy link
Contributor Author

This does fix the current build, so I'm going to merge.

If someone wants to implement a more long-term solution, I will gladly review that PR

https://github.com/NixOS/nixpkgs/pull/82757
1 package built:
unityhub

@jonringer jonringer merged commit 2a56d98 into NixOS:master Mar 23, 2020
@jonringer jonringer deleted the fix-unityhub branch March 23, 2020 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ma27 Ma27 Ma27 left review comments

@timstott timstott timstott approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@jonringer @veprbl @ar1a @nh2 @timstott @Ma27