Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

elmPackages.elm-instrument: Init at 0.0.7 #82746

Merged
merged 1 commit into from Mar 16, 2020

Conversation

turboMaCk
Copy link
Member

Init elm-instrument

  • This package is not that useful on its own but it's a first logical step for packaging elm-coverage
  • PR to upstream we're currently using as a patch
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @domenkozar this is part 1/2 of bringing elm-coverage in. I think doing it one by one will result in clearer diff in PRs. Alternatively I can continue on node.js side within this PR.

@turboMaCk
Copy link
Member Author

@GrahamcOfBorg build elmPackages.elm-instrument

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants