nixos/networking-interfaces: change preferTempAddress to allow disabling temp addresses #78843
+61
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
6.topic: nixos
|
@GrahamcOfBorg test networking.scripted.privacy networking.networkd.privacy |
lheckemann
approved these changes
Feb 1, 2020
| // listToAttrs (forEach interfaces | ||
| (i: let | ||
| opt = i.tempAddress; | ||
| val = if opt == "disabled" then 0 else |
There was a problem hiding this comment.
{disabled = 0; enabled = 1; default = 2;}.${opt} might be clearer?
There was a problem hiding this comment.
Oh, nice! I didn't think about this.
|
@GrahamcOfBorg test networking.scripted.privacy networking.networkd.privacy |
|
Ok, I applied your suggestion. The tests passes on my end. Let's test again with: @GrahamcOfBorg test networking.scripted.privacy networking.networkd.privacy |
|
Thank you! |
anna328p
pushed a commit
to anna328p/nixpkgs
that referenced
this pull request
Feb 2, 2020
nixos/networking-interfaces: change preferTempAddress to allow disabling temp addresses
dtzWill
pushed a commit
to dtzWill/nixpkgs
that referenced
this pull request
Feb 6, 2020
nixos/networking-interfaces: change preferTempAddress to allow disabling temp addresses (cherry picked from commit 3af5a40)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Fix issue #75311
Things done
nixosTests.networking.scripted.privacynixosTests.networking.networkd.privacy