Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/doc/network-manager: updates #78838

Merged
merged 1 commit into from Feb 1, 2020
Merged

nixos/doc/network-manager: updates #78838

merged 1 commit into from Feb 1, 2020

Conversation

worldofpeace
Copy link
Contributor

Motivation for this change

Fixes #71161

cc @jtojnar @JohnAZoidberg

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace worldofpeace added this to the 20.03 milestone Jan 30, 2020
@worldofpeace worldofpeace merged commit 9cb395a into NixOS:master Feb 1, 2020
@worldofpeace worldofpeace deleted the nm-doc-update branch February 1, 2020 23:08
anna328p pushed a commit to anna328p/nixpkgs that referenced this pull request Feb 2, 2020
@worldofpeace @anna328p
Merge pull request NixOS#78838 from worldofpeace/nm-doc-update
db284f1 
nixos/doc/network-manager: updates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnAZoidberg JohnAZoidberg JohnAZoidberg left review comments

Assignees
No one assigned
Labels
6.topic: nixos 8.has: documentation 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
20.03
Development

Successfully merging this pull request may close these issues.

NetworkManager docs erroneously state you can't use networking.wireless
2 participants
@worldofpeace @JohnAZoidberg