Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update xfce docs #78839

Merged
merged 4 commits into from
Feb 1, 2020
Merged

Update xfce docs #78839

merged 4 commits into from
Feb 1, 2020
+6 −17

Conversation

worldofpeace
Copy link
Contributor

Motivation for this change

The module has basically been rewrote and things aren't like they were.
The one bit of these docs that I think might be misleading/pointless is the troubleshooting section.
I'm not sure any of that is valid/relevant anymore.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@worldofpeace worldofpeace added this to the 20.03 milestone Jan 30, 2020
@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: xfce The Xfce Desktop Environment 8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Jan 30, 2020
@worldofpeace worldofpeace requested a review from jtojnar January 31, 2020 22:39
jtojnar
jtojnar reviewed Feb 1, 2020
View reviewed changes
nixos/doc/manual/configuration/xfce.xml
@@ -30,16 +30,6 @@
(system wide), put them into your
<xref linkend="opt-environment.systemPackages"/>.
</para>
<simplesect xml:id="sec-xfce-thunar-volumes">
<title>Thunar Volume Support</title>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this was meant as a proxy for GVFS, when Thunar is used outside of Xfce?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But not sure if we need that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't even seem to make sense to me at all either, it says to just enable xfce.

jtojnar
jtojnar approved these changes Feb 1, 2020
View reviewed changes
Copy link
Member

@jtojnar jtojnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@worldofpeace worldofpeace merged commit 8a8f03e into NixOS:master Feb 1, 2020
anna328p pushed a commit to anna328p/nixpkgs that referenced this pull request Feb 2, 2020
@worldofpeace @anna328p
Merge pull request NixOS#78839 from worldofpeace/update-xfce-docs

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
13255ae 
Update xfce docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: xfce The Xfce Desktop Environment 8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
20.03
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@worldofpeace @jtojnar