pythonPackages.scs: init at 2.1.1 #78897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
|
@GrahamcOfBorg build python3Packages.scs |
bhipple
requested changes
Jan 31, 2020
|
I had originally done that but wasn't sure what the best/most replicable
way of moving the C source to source/scs was. I will look at the quoted
example.
…On Thu, Jan 30, 2020, 7:56 PM Benjamin Hipple ***@***.***> wrote:
***@***.**** requested changes on this pull request.
------------------------------
In pkgs/development/python-modules/scs/default.nix
<#78897 (comment)>:
> + # check inputs
+, nose
+}:
+
+buildPythonPackage rec {
+ pname = "scs";
+ version = "2.1.1";
+
+ disabled = pythonOlder "3.5";
+
+ src = fetchFromGitHub {
+ owner = "bodono";
+ repo = "scs-python";
+ rev = "f02abdc0e2e0a5851464e30f6766ccdbb19d73f0"; # need to choose commit manually, untagged
+ sha256 = "01ghvyylxql7jvdcwy65wf7y5qykqyqkbysy402zfhgmm9dxizgv";
+ fetchSubmodules = true;
Ihttps://github.com/bodono/scs-python/blob/master/setup.py
If you look at what the upstream src repo and setup.py are doing, it
appears they're shipping the scs C library as a git submodule, then
having python recompile it from scratch.
In the nix distro, we generally prefer to have the C package stand-alone,
then have the python package just link the package as a proper distribution
dependency without vendoring. An example of a package that does this is
pyarrow:
https://github.com/NixOS/nixpkgs/blob/master/pkgs/development/python-modules/pyarrow/default.nix
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#78897?email_source=notifications&email_token=ACNZYI3UY24VSDUTC4WZ2A3RANZKLA5CNFSM4KN26G32YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCTXX7SY#pullrequestreview-351240139>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACNZYI5HCGHDBXIUM4UDW6DRANZKLANCNFSM4KN26G3Q>
.
|
drewrisinger
force-pushed
the
dr-pr-python-scs
branch
from
f8a941d
to
b9808b8
Compare
|
@GrahamcOfBorg eval |
|
@bhipple suggested changes made. Please review/approve. |
jonringer
reviewed
Feb 3, 2020
drewrisinger
force-pushed
the
dr-pr-python-scs
branch
3 times, most recently
from
54adba1
to
b6b185b
Compare
jonringer
reviewed
Feb 3, 2020
jonringer
reviewed
Feb 3, 2020
Depends on libraries.science.math.scs. Required by cvxpy -> qiskit-aer. Co-authored-by: bhipple <bhipple@users.noreply.github.com>
drewrisinger
force-pushed
the
dr-pr-python-scs
branch
from
b6b185b
to
404163e
Compare
|
@GrahamcOfBorg build pythonPackages.scs |
bhipple
approved these changes
Feb 4, 2020
There was a problem hiding this comment.
Looks much nicer now! Thanks for the help with best practices too, @jonringer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Add dependency for qiskit (cvxpy's dependency).
Python interface for C Splitting Cone Solver. C Package in tree at
lib.science.math.scs.Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)