Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.cvxpy: init at 1.0.25 #78898

Merged
merged 1 commit into from Feb 22, 2020
Merged

pythonPackages.cvxpy: init at 1.0.25 #78898

merged 1 commit into from Feb 22, 2020

Conversation

drewrisinger
Copy link
Contributor

@drewrisinger drewrisinger commented Jan 30, 2020 •
edited

Motivation for this change

Add dependency for upcoming qiskit package #78772 @jonringer
Depends on #78897

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer
Copy link
Contributor

please fix eval

@drewrisinger
Copy link
Contributor Author

@GrahamcOfBorg eval

jonringer
jonringer reviewed Feb 18, 2020
View reviewed changes
pkgs/development/python-modules/cvxpy/default.nix
, ecos
, multiprocess
, numpy
, osqp
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like osqp doesn't exist yet

python-modules/cvxpy/default.nix:1:1 called without required argument 'osqp'

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops. Waiting on #78883

@FRidh
Copy link
Member

FRidh commented Feb 19, 2020

please rebase

@drewrisinger
Copy link
Contributor Author

Rebased, but still waiting on #78897

@jonringer
Copy link
Contributor

merged, sorry about that

@jonringer
Copy link
Contributor

@GrahamcOfBorg eval

@drewrisinger
pythonPackages.cvxpy: init at 1.0.25
261b30a 
Convex optimization problem modeler in Python.
Dependency of qiskit-aer.
@drewrisinger
Copy link
Contributor Author

@GrahamcOfBorg build python37Packages.cvxpy python38Packages.cvxpy

@drewrisinger
Copy link
Contributor Author

bot builds fail b/c scs package uses mkl (non-free).

This was referenced Feb 20, 2020
Closed
Merged
jonringer
jonringer approved these changes Feb 22, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM
commit LGTM
has tests 👍

[9 built, 19 copied (65.8 MiB), 12.9 MiB DL]
https://github.com/NixOS/nixpkgs/pull/78898
2 package built:
python37Packages.cvxpy python38Packages.cvxpy

@jonringer jonringer merged commit d38b8d8 into NixOS:master Feb 22, 2020
@drewrisinger drewrisinger mentioned this pull request Feb 24, 2020
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@drewrisinger @jonringer @FRidh