Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build.dsl: allow strings to be used as connector numbers #313

Closed
nmigen-issue-migration opened this issue Jan 26, 2020 · 2 comments
Closed

build.dsl: allow strings to be used as connector numbers #313

nmigen-issue-migration opened this issue Jan 26, 2020 · 2 comments

Comments

@nmigen-issue-migration
Copy link

Issue by anuejn
Sunday Jan 26, 2020 at 17:37 GMT
Originally opened as m-labs/nmigen#313

follow up of #311 .
Is it as simple as that or did I miss something?

anuejn included the following code: https://github.com/m-labs/nmigen/pull/313/commits
@nmigen-issue-migration
Copy link
Author

Comment by codecov[bot]
Sunday Jan 26, 2020 at 17:48 GMT

Codecov Report

Merging #313 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #313   +/-   ##
=======================================
  Coverage   82.09%   82.09%           
=======================================
  Files          34       34           
  Lines        5659     5659           
  Branches     1163     1163           
=======================================
  Hits         4646     4646           
  Misses        862      862           
  Partials      151      151
Impacted Files Coverage Δ
nmigen/build/dsl.py 93.75% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c42c3a0...04b8ee5. Read the comment docs.

@whitequark
Copy link
Member

@anuejn Merged, with slight modifications: I reworded the error messages, and added tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@whitequark @nmigen-issue-migration