elementary-planner: init at 2.1.1 #78859
Conversation
Upstream doesn't use the name "elementary-planner", but rename in our packaging and be consistent about it to avoid confusion with gnome's planner.
|
So I was a bit worried about this name for second, but it seems their todo app is called tasks https://github.com/elementary/tasks, so there won't be two |
There was a problem hiding this comment.
@dtzWill You must be the soverign when it comes to packaging todo apps 😄
Like todo app paradox, within the todo app is a todo to package a todo app. (jk)
Anyways, comments where I mentioned "where is this used?' is because I couldn't find it.
I also would like to see upstream fixing that version string.
| gtk3 | ||
| pantheon.granite | ||
| webkitgtk | ||
| appstream |
There was a problem hiding this comment.
where do we need appstream?
There was a problem hiding this comment.
Possibly for appstream It's file for merging the localisations into appstream file?
There was a problem hiding this comment.
Don't remember! Possibly sources:
- I've been tracking this since before it was usable, maybe it needed/asked for it previously and I missed the drop
- The in-tree
debian/controlmentionsappstreaminBuild-Depends:so maybe based initial deps on that list - I maybe copied from another expression that does need appstream :3.
In short, thank you for checking these and pushing back on unnecessary deps-- this has been working so I forgot I put it together rather sloppily. Sorry about that :3.
FWIW I believe libical isn't asked for when a sufficiently new libecal (evolution-data-server) but I provided anyway so this works with, for example, my tree which has yet to om nom the gnome 3.34 updates O:).
But I'm happy to remove it, which is why I bring it up ;).
There was a problem hiding this comment.
git log -p -Gappstream suggests it was used for things like appstreamcli validate on the appdata.xml or so?
Removing, will see how that pans out :).
|
This thing is pretty cute: Might swap out gnome-todo because it's not seeing releases in a while. Edit: not the only one who noticed alainm23/planify#185 😁 |
ofborg
bot
added
8.has: package (new)
Per reviewer feedback, thanks all! <3
LMAO this is very true. I definitely have a TODO for this and others :D. |
|
(pushed update, review feedback should now be addressed!) |
Motivation for this change
"Never worry about forgetting things again"
cc @worldofpeace
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)