Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

elementary-planner: init at 2.1.1 #78859

Merged
merged 3 commits into from Feb 3, 2020

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Jan 30, 2020

Motivation for this change

"Never worry about forgetting things again"

cc @worldofpeace

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Upstream doesn't use the name "elementary-planner",
but rename in our packaging and be consistent about it
to avoid confusion with gnome's planner.
@worldofpeace
Copy link
Contributor

So I was a bit worried about this name for second, but it seems their todo app is called tasks https://github.com/elementary/tasks, so there won't be two elementary-planner in here 😄

Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dtzWill You must be the soverign when it comes to packaging todo apps 😄
Like todo app paradox, within the todo app is a todo to package a todo app. (jk)

Anyways, comments where I mentioned "where is this used?' is because I couldn't find it.
I also would like to see upstream fixing that version string.

pkgs/applications/office/elementary-planner/default.nix Outdated Show resolved Hide resolved
pkgs/applications/office/elementary-planner/default.nix Outdated Show resolved Hide resolved
pkgs/applications/office/elementary-planner/default.nix Outdated Show resolved Hide resolved
gtk3
pantheon.granite
webkitgtk
appstream
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where do we need appstream?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possibly for appstream It's file for merging the localisations into appstream file?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't remember! Possibly sources:

  • I've been tracking this since before it was usable, maybe it needed/asked for it previously and I missed the drop
  • The in-tree debian/control mentions appstream in Build-Depends: so maybe based initial deps on that list
  • I maybe copied from another expression that does need appstream :3.

In short, thank you for checking these and pushing back on unnecessary deps-- this has been working so I forgot I put it together rather sloppily. Sorry about that :3.

FWIW I believe libical isn't asked for when a sufficiently new libecal (evolution-data-server) but I provided anyway so this works with, for example, my tree which has yet to om nom the gnome 3.34 updates O:).

But I'm happy to remove it, which is why I bring it up ;).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

git log -p -Gappstream suggests it was used for things like appstreamcli validate on the appdata.xml or so?

Removing, will see how that pans out :).

pkgs/applications/office/elementary-planner/default.nix Outdated Show resolved Hide resolved
@worldofpeace
Copy link
Contributor

worldofpeace commented Jan 30, 2020

This thing is pretty cute:
Screenshot from 2020-01-30 09 52 12

Might swap out gnome-todo because it's not seeing releases in a while.

Edit: not the only one who noticed alainm23/planify#185 😁

@dtzWill
Copy link
Member Author

dtzWill commented Feb 3, 2020

@dtzWill You must be the soverign when it comes to packaging todo apps smile
Like todo app paradox, within the todo app is a todo to package a todo app. (jk)

LMAO this is very true. I definitely have a TODO for this and others :D.

@dtzWill
Copy link
Member Author

dtzWill commented Feb 3, 2020

(pushed update, review feedback should now be addressed!)

@ofborg ofborg bot requested a review from worldofpeace February 3, 2020 06:30
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot 😄

@worldofpeace worldofpeace merged commit 2158ec6 into NixOS:master Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants