Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dotnetCorePackages: Fix closure size #78855

Merged
merged 1 commit into from Feb 2, 2020

Conversation

baracoder
Copy link
Contributor

@baracoder baracoder commented Jan 30, 2020

Motivation for this change

Fix closure size, which results in copying env-vars to output directory. See #73262

% nix why-depends /nix/store/8w7566287q3zalhn0xixl9610ssqirfx-dotnet-sdk-3.1.100 /nix/store/cc94mviqcb0wpqq5488p7a0ggp8v3hny-dotnet-sdk-3.1.100-linux-x64.tar.gz
/nix/store/8w7566287q3zalhn0xixl9610ssqirfx-dotnet-sdk-3.1.100
╚═══env-vars: …=".".declare -x src="/nix/store/cc94mviqcb0wpqq5488p7a0ggp8v3hny-dotnet-sdk-3.1.100-linux-x64.ta…
    => /nix/store/cc94mviqcb0wpqq5488p7a0ggp8v3hny-dotnet-sdk-3.1.100-linux-x64.tar.gz
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer
Copy link
Contributor

wow, this cuts down the closure size by almost half

[nix-shell:~/.cache/nixpkgs-review/pr-78855-2]$ nix path-info -Sh ./results/dotnet-sdk_3
/nix/store/ipq4myhb1bxmi93c5l8r3i42qp33q14l-dotnet-sdk-3.1.101	 387.4M
[nix-shell:~/projects/nixpkgs]$ nix path-info -Sh ./result
/nix/store/f3cvcvf900h9svrn52dj2cnz63zy3f23-dotnet-sdk-3.1.101	 687.6M

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM
was able to compile project with changes

https://github.com/NixOS/nixpkgs/pull/78855
16 package built:
dotnet-aspnetcore dotnet-netcore dotnet-sdk dotnet-sdk_3 dotnetCorePackages.aspnetcore_3_0 dotnetCorePackages.aspnetcore_3_1 dotnetCorePackages.netcore_3_0 dotnetCorePackages.netcore_3_1 dotnetCorePackages.sdk_3_0 eventstore fsharp41 jellyfin msbuild python37Packages.dotnetcore2 python38Packages.dotnetcore2 wasabiwallet

@jonringer
Copy link
Contributor

@GrahamcOfBorg build dotnet-sdk

@jonringer jonringer merged commit f22e45a into NixOS:master Feb 2, 2020
@baracoder baracoder deleted the dotnetcore-fixup-closure branch February 2, 2020 16:04
@baracoder baracoder restored the dotnetcore-fixup-closure branch February 2, 2020 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants