Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ocamlformat: 0.12 -> 0.13.0 #78942

Merged
merged 1 commit into from Jan 31, 2020
Merged

ocamlformat: 0.12 -> 0.13.0 #78942

merged 1 commit into from Jan 31, 2020

Conversation

anmonteiro
Copy link
Member

@anmonteiro anmonteiro commented Jan 31, 2020 •
edited

Motivation for this change

https://github.com/ocaml-ppx/ocamlformat/releases/tag/0.13.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @Zimmi48

@ofborg ofborg bot requested a review from Zimmi48 January 31, 2020 06:02
@Zimmi48
Copy link
Member

Zimmi48 commented Jan 31, 2020

@vbgl Can I ask you to merge this PR?

@vbgl
Copy link
Contributor

vbgl commented Jan 31, 2020

@GrahamcOfBorg build ocamlformat

@vbgl vbgl merged commit a21c2fa into NixOS:master Jan 31, 2020
anna328p pushed a commit to anna328p/nixpkgs that referenced this pull request Feb 2, 2020
@anmonteiro @anna328p
ocamlformat: 0.12 -> 0.13.0 (NixOS#78942)
5683e65
jpgu-epam pushed a commit to jpgu-epam/nixpkgs that referenced this pull request Feb 4, 2020
@anmonteiro @jpgu-epam
ocamlformat: 0.12 -> 0.13.0 (NixOS#78942)
c4af79c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zimmi48 Zimmi48 Zimmi48 approved these changes

Assignees
No one assigned
Labels
6.topic: ocaml 8.has: package (update) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@anmonteiro @Zimmi48 @vbgl