pythonPackages.dlx: init at 1.0.4 #78873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewrisinger
force-pushed
the
dr-pr-python-dlx
branch
from
1f70a94
to
c1e4f9a
Compare
FRidh
requested changes
Feb 9, 2020
Python implementation of Donald Knuth's Dancing Links (exact cover) algorithm. Requirement of qiskit-aqua.
drewrisinger
force-pushed
the
dr-pr-python-dlx
branch
from
c1e4f9a
to
419caf0
Compare
jonringer
approved these changes
Feb 12, 2020
There was a problem hiding this comment.
diff LGTM
upstream seems pretty inactive (4 commits in the past year), however, seems to be pretty stable and builds for python38, so that's acceptable to me
has tests 👍
commits LGTM
[5 built, 1 copied (0.5 MiB), 0.1 MiB DL]
https://github.com/NixOS/nixpkgs/pull/78873
3 package built:
python27Packages.dlx python37Packages.dlx python38Packages.dlx
|
@GrahamcOfBorg build python27Packages.dlx python37Packages.dlx python38Packages.dlx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Add dependency for upcoming qiskit-terra package #78772 @jonringer
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)