libcint: init at 3.0.19 #78871
Merged
libcint: init at 3.0.19 #78871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
8.has: package (new)
10.rebuild-darwin: 0
10.rebuild-linux: 1-10
labels
drewrisinger
force-pushed
the
dr-pr-libcint
branch
from
1a6d03b
to
6aaed65
Compare
10 tasks
|
@GrahamcOfBorg build libcint |
timokau
requested changes
Feb 3, 2020
There was a problem hiding this comment.
The commit name libraries.libcint suggests that libcint is part of the libraries package set (i.e. that you can nix build libraries.libcint. The commit should just be libcint: init....
A rebase on latest master would be nice, since the maintainer commit is already merged.
drewrisinger
force-pushed
the
dr-pr-libcint
branch
2 times, most recently
from
8ed31b4
to
ecc2922
Compare
C library of general GTO integrals for quantum chemistry. Requirement for pyscf, which is a requirement for qiskit-aqua.
drewrisinger
changed the title
drewrisinger
force-pushed
the
dr-pr-libcint
branch
from
ecc2922
to
3e5789a
Compare
|
@timokau thanks for your review/comments. Much appreciated. All changes made, and notes made on python2 requirement. |
timokau
approved these changes
Feb 3, 2020
|
Looks perfect, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Add dependency for upcoming qiskit-terra package #78772
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)