Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gnugp22: try to fix dates (r13y) #78781

Closed
wants to merge 1 commit into from

Conversation

grahamc
Copy link
Member

@grahamc grahamc commented Jan 29, 2020

It doesn't work, though, and man pages in $out/share/man/ still use
today's date.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

It doesn't work, though, and man pages in $out/share/man/ still use
today's date.
@grahamc
Copy link
Member Author

grahamc commented Jan 29, 2020

@jtojnar suggested https://bugs.debian.org/cgi-bin/bugreport.cgi?att=1;bug=806494;filename=gnupg.diff.txt;msg=5 but after checking, that patch is already applied for 2.2.

@bhipple
Copy link
Contributor

bhipple commented Feb 11, 2020

diff --git a/pkgs/tools/security/gnupg/22.nix b/pkgs/tools/security/gnupg/22.nix
index 9aa92fd6829..82c9c312611 100644
--- a/pkgs/tools/security/gnupg/22.nix
+++ b/pkgs/tools/security/gnupg/22.nix
@@ -41,6 +41,8 @@ stdenv.mkDerivation rec {
     sed -i 's,"libpcsclite\.so[^"]*","${stdenv.lib.getLib pcsclite}/lib/libpcsclite.so",g' scd/scdaemon.c
   ''; #" fix Emacs syntax highlighting :-(
 
+  preConfigure = "export SOURCE_DATE_EPOCH=1";
+
   pinentryBinaryPath = pinentry.binaryPath or "bin/pinentry";
   configureFlags = [
     "--with-libgpg-error-prefix=${libgpgerror.dev}"

On my NixOS machine with sandboxes on the current master branch, this is all that's required to make nix-build --check pass, or so it seems.

@wamserma wamserma mentioned this pull request May 15, 2020
10 tasks
@prusnak
Copy link
Member

prusnak commented Jul 27, 2020

Superseded by #93976

@prusnak prusnak closed this Jul 27, 2020
Staging automation moved this from WIP to Done Jul 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Staging
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants