Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixosTests.gnome3: port to python #76157

Merged
merged 2 commits into from Jan 30, 2020
Merged

nixosTests.gnome3: port to python #76157

merged 2 commits into from Jan 30, 2020

Conversation

worldofpeace
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@worldofpeace
Copy link
Contributor Author

@GrahamcOfBorg test gnome3

@ofborg ofborg bot added 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: nixos labels Dec 22, 2019
@worldofpeace
Copy link
Contributor Author

Subtest is pretty unhelpful, I don't think I know what test failed...

@worldofpeace
Copy link
Contributor Author

Ok, with new logging I can see what test exactly failed:

The following tests have failed:
 - Test "Login to GNOME with GDM" failed with error: "retrieving systemctl info for unit "default.target" under user "alice" failed with exit code 1"
cleaning up

maybe e4b5bc1 does the trick on ofborg too.

@worldofpeace
Copy link
Contributor Author

@GrahamcOfBorg test gnome3

@worldofpeace
Copy link
Contributor Author

Uhhmm, aarch64 is broken for gnome. Will fix that but the test passes now.

@worldofpeace
Copy link
Contributor Author

#78846

@worldofpeace
Copy link
Contributor Author

@tfc @flokli @adisbladis

@worldofpeace
nixosTests.gnome3: port to python
9888b30
@worldofpeace
nixosTests.gnome3: wait_for_wayland at login
7651fcf 
This prevents the default.target check from just failing.
Blaming it on using systemctl in wait_for_unit (and it's particularly
buggy for user units).
jtojnar
jtojnar approved these changes Jan 30, 2020
View reviewed changes
Copy link
Contributor

@jtojnar jtojnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good at a glance.

@worldofpeace worldofpeace merged commit 30bfbe7 into NixOS:master Jan 30, 2020
@worldofpeace worldofpeace deleted the port-gnome3-test branch January 30, 2020 23:10
anna328p pushed a commit to anna328p/nixpkgs that referenced this pull request Feb 2, 2020
@worldofpeace @anna328p
Merge pull request NixOS#76157 from worldofpeace/port-gnome3-test
35e628f 
nixosTests.gnome3: port to python
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tfc tfc tfc left review comments

@jtojnar jtojnar jtojnar approved these changes

@hedning hedning Awaiting requested review from hedning

Assignees
No one assigned
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: nixos 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@worldofpeace @tfc @jtojnar