nix-review result:

error: build of '/nix/store/s27xjzgf8vq8h7jisvqdny2z6bwyc9dv-env.drv' failed
1 package failed to build:
lumo

28 package built:
antora bitwarden-cli create-cycle-app dat emojione fast-cli gtop hueadm image_optim iosevka joplin lessc pulp python37Packages.jupyterhub python37Packages.jupyterhub-ldapauthenticator python37Packages.oauthenticator python38Packages.jupyterhub python38Packages.jupyterhub-ldapauthenticator python38Packages.oauthenticator sage sageWithDoc shout sloc styx thelounge triton twemoji-color-font wasm-text-gen

But apparently lumo already doesn't build.

Is yaml-language-server a program? If so, it should be exposed in all-packages.nix.

@alyssais Good point, yes it provides a yaml-language-server executable. I've pushed a new version that adds it to all-packages.nix.

This'll need a rebase, but from my understanding of the node stuff in nix, this looks straight-forward enough to merge? Not sure if there's someone who "owns" the node part of nixpkgs who should have been pinged for this?

Not sure if I'm using nix-review wrong or what, but I can't verify if the binary actually runs (and @rycee didn't tick that box)

Heh, I entirely forgot about this. I've been using the binary for some time in my own branch and it works well. I'll try a rebase and merge if it builds ok.

Rebased to master in 8883371.