Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: 30bfbe7e81b6
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: 6ea79d2707e0
Choose a head ref
  • 12 commits
  • 11 files changed
  • 1 contributor

Commits on Jan 30, 2020

  1. nixos/mailman: add webUser option

    Not everybody is using Apache.
    alyssais committed Jan 30, 2020
    Copy the full SHA
    547b91b View commit details
    Browse the repository at this point in the history
  2. nixos/mailman: siteOwner default -> example

    A default of example.com is useful to nobody.  The correct value of
    this depends on the system.
    alyssais committed Jan 30, 2020
    Copy the full SHA
    112fa07 View commit details
    Browse the repository at this point in the history
  3. nixos/mailman: don't keep secrets in the Nix store

    This replaces all Mailman secrets with ones that are generated the
    first time the service is run.  This replaces the hyperkittyApiKey
    option, which would lead to a secret in the world-readable store.
    Even worse were the secrets hard-coded into mailman-web, which are not
    just world-readable, but identical for all users!
    
    services.mailman.hyperkittyApiKey has been removed, and so can no
    longer be used to determine whether to enable Hyperkitty.  In its
    place, there is a new option, services.mailman.hyperkitty.enable.  For
    consistency, services.mailman.hyperkittyBaseUrl has been renamed to
    services.mailman.hyperkitty.baseUrl.
    alyssais committed Jan 30, 2020
    Copy the full SHA
    c397d19 View commit details
    Browse the repository at this point in the history
  4. Copy the full SHA
    f254fb9 View commit details
    Browse the repository at this point in the history
  5. Copy the full SHA
    bc8eece View commit details
    Browse the repository at this point in the history
  6. Copy the full SHA
    db0a371 View commit details
    Browse the repository at this point in the history
  7. nixos/mailman: don't set Postfix hashes

    It's likely that a user might want to set multiple values for
    relay_domains, transport_maps, and local_recipient_maps, and the order
    is significant.  This means that there's no good way to set these
    across multiple NixOS modules, and they should probably all be set
    together in the user's Postfix configuration.
    
    So, rather than setting these in the Mailman module, just make the
    Mailman module check that the values it needs to occur somewhere, and
    advise the user on what to set if not.
    alyssais committed Jan 30, 2020
    Copy the full SHA
    8d9636e View commit details
    Browse the repository at this point in the history
  8. mailman: init package for Mailman CLI

    We already had python3Packages.mailman, but that's only really usable
    as a library.  The only other option was to create a whole Python
    environment, which was undesirable to install as a system-wide
    package.
    alyssais committed Jan 30, 2020
    Copy the full SHA
    a8538a7 View commit details
    Browse the repository at this point in the history
  9. mailman-web: use upstream, improve NixOS module

    Previously, some files were copied into the Nixpkgs tree, which meant
    we wouldn't easily be able to update them, and was also just messy.
    
    The reason it was done that way before was so that a few NixOS
    options could be substituted in.  Some problems with doing it this way
    were that the _package_ changed depending on the values of the
    settings, which is pretty strange, and also that it only allowed those
    few settings to be set.
    
    In the new model, mailman-web is a usable package without needing to
    override, and I've implemented the NixOS options in a much more
    flexible way.  NixOS' mailman-web config file first reads the
    mailman-web settings to use as defaults, but then it loads another
    configuration file generated from the new services.mailman.webSettings
    option, so _any_ mailman-web Django setting can be customised by the
    user, rather than just the three that were supported before.  I've
    kept the old options, but there might not really be any good reason to
    keep them.
    alyssais committed Jan 30, 2020
    Copy the full SHA
    881dd99 View commit details
    Browse the repository at this point in the history
  10. Copy the full SHA
    8f4fd4d View commit details
    Browse the repository at this point in the history
  11. nixos/mailman: make mailman package configurable

    This will allow users to provide other archiver plugins than the
    default mailman-hyperkitty.
    alyssais committed Jan 30, 2020
    Copy the full SHA
    0167eb3 View commit details
    Browse the repository at this point in the history
  12. Copy the full SHA
    6ea79d2 View commit details
    Browse the repository at this point in the history