Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swiftformat: 0.44.0 -> 0.44.2 #78807

Merged
merged 1 commit into from Feb 16, 2020
Merged

Conversation

bdesham
Copy link
Contributor

@bdesham bdesham commented Jan 30, 2020

Motivation for this change

Update for the following changes in the program:

0.44.2 (2020-02-02)

  • Fixed crash in line wrapping logic
  • Fixed several cases where braces were not correctly moved according to wrap rule
  • Prevented wrapping of image and color literals
  • Fixed bug with trailingClosures rule breaking unwrap operators

0.44.1 (2020-01-26)

  • Fixed spaceInsideComments rule mangling preformatted comments with multiple slashes
  • Fixed redundantFileprivate breaking code relying on type-inference for init
  • Reverted overly aggressive argument wrapping change in 0.44.0
  • Fixed redundantParens rule breaking #if statements without space before argument
  • Fixed // swiftformat:disable directives not affecting wrap or wrapArguments rules
  • Fixed bug where yodaConditions rule caused formatting to never terminate
  • Fixed crash in fileHeader rule

Things done

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bdesham bdesham changed the title swiftformat: 0.44.0 -> 0.44.1 swiftformat: 0.44.0 -> 0.44.2 Feb 15, 2020
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/100

@JohnAZoidberg JohnAZoidberg merged commit 759ae67 into NixOS:master Feb 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants