Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.ecos: init at 2.0.7.post1 #78882

Merged
merged 1 commit into from Feb 19, 2020
Merged

pythonPackages.ecos: init at 2.0.7.post1 #78882

merged 1 commit into from Feb 19, 2020

Conversation

drewrisinger
Copy link
Contributor

Motivation for this change

Add dependency for upcoming qiskit package #78772
Split from #78772 per request

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@drewrisinger
Copy link
Contributor Author

Depends on #79187

@ofborg ofborg bot requested a review from bhipple February 3, 2020 23:47
@jonringer
Copy link
Contributor

please address conflicts

@drewrisinger
pythonPackages.ecos: init at 2.0.7.post1
36cea1c 
Embedded cone solver interface for optimization problems in Python.
Dependency of qiskit-ignis.
@drewrisinger
Copy link
Contributor Author

conflicts should be resolved.

jonringer
jonringer approved these changes Feb 19, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM
has tests 👍

[4 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/78882
2 package built:
python37Packages.ecos python38Packages.ecos

@jonringer
Copy link
Contributor

@GrahamcOfBorg build python37Packages.ecos python38Packages.ecos

@jonringer jonringer merged commit 3adda62 into NixOS:master Feb 19, 2020
@drewrisinger drewrisinger deleted the dr-pr-python-ecos branch February 20, 2020 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@bhipple bhipple Awaiting requested review from bhipple

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@drewrisinger @jonringer