Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nushell: 0.8.0 -> 0.9.0 #78782

Merged
merged 1 commit into from Feb 1, 2020
Merged

nushell: 0.8.0 -> 0.9.0 #78782

merged 1 commit into from Feb 1, 2020

Conversation

cust0dian-old
Copy link
Contributor

@cust0dian-old cust0dian-old commented Jan 29, 2020 •
edited

Motivation for this change

https://github.com/nushell/nushell/releases/tag/0.9.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from marsam and Br1ght0ne January 29, 2020 20:23
Br1ght0ne
Br1ght0ne approved these changes Jan 29, 2020
View reviewed changes
Copy link
Member

@Br1ght0ne Br1ght0ne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM
nixpkgs-review passes on NixOS

@evanjs
Copy link
Member

evanjs commented Jan 30, 2020 •
edited

Tests are failing on NixOS

output from build 
running 53 tests
test commands::classified::external::tests::checks_contains_whitespace_from_argument_to_be_passed_in ... ok
test commands::classified::external::tests::adds_quotes_to_argument_to_be_passed_in ... ok
test commands::classified::external::tests::checks_quotes_from_argument_to_be_passed_in ... ok
test commands::classified::external::tests::does_not_expand_tilde_if_tilde_is_not_first_character ... ok
test commands::classified::external::tests::strips_quotes_from_argument_to_be_passed_in ... ok
test commands::classified::external::tests::expands_tilde_if_starts_with_tilde_character ... ok
test commands::from_ssv::tests::it_allows_a_predefined_number_of_spaces ... ok
test commands::from_ssv::tests::it_deals_with_single_column_input ... ok
test commands::classified::external::tests::identifies_command_not_found ... ok
test commands::from_ssv::tests::it_returns_none_given_an_empty_string ... ok
test commands::from_ssv::tests::it_handles_empty_values_when_headerless_and_aligned_columns ... ok
test commands::from_ssv::tests::it_keeps_empty_columns ... ok
test commands::from_ssv::tests::it_trims_remaining_separator_space ... ok
test commands::from_ssv::tests::it_uses_first_row_as_data_when_headerless ... ok
test commands::from_ssv::tests::it_uses_the_full_final_column ... ok
test commands::from_ssv::tests::it_trims_empty_and_whitespace_only_lines ... ok
test commands::from_xml::tests::parses_empty_element ... ok
test commands::from_xml::tests::parses_element_with_text ... ok
test commands::from_xml::tests::parses_element_with_attribute ... ok
test commands::from_xml::tests::parses_element_with_multiple_attributes ... ok
test commands::from_ssv::tests::input_is_parsed_correctly_if_either_option_works ... ok
test commands::from_xml::tests::parses_element_with_attribute_and_element ... ok
test commands::from_xml::tests::parses_element_with_elements ... ok
test data::base::tests::column_path_that_contains_just_a_number_gets_a_row_from_a_row ... ok
test data::base::tests::gets_first_matching_field_from_rows_with_same_field_inside_a_table ... ok
test data::base::tests::gets_matching_field_from_a_row ... ok
test commands::split_by::tests::errors_if_key_within_some_inner_table_is_missing ... ok
test data::base::tests::column_path_that_contains_just_a_number_gets_a_row_from_a_table ... ok
test data::base::tests::gets_matching_field_from_nested_rows_inside_a_row ... ok
test data::base::tests::replaces_matching_field_from_a_row ... ok
test commands::group_by::tests::groups_table_by_country_column ... ok
test data::base::tests::replaces_matching_field_from_nested_rows_inside_a_row ... ok
test deserializer::tests::check_type_name_properties ... ok
test data::base::tests::replaces_matching_field_from_rows_inside_a_table ... ok
test commands::group_by::tests::groups_table_by_date_column ... ok
test env::environment::tests::picks_up_path_variables_from_configuration ... ok
test env::environment::tests::does_not_update_env_variable_if_it_exists ... ok
test env::environment::tests::updates_env_variable ... ok
test utils::data_processing::tests::evaluator_fetches_by_column_if_supplied_a_column_name ... ok
test utils::data_processing::tests::evaluator_returns_1_if_no_column_name_given ... ok
test utils::data_processing::tests::reducer_computes_given_a_sum_command ... ok
test env::environment::tests::updates_path_variable ... ok
test env::environment::tests::picks_up_environment_variables_from_configuration ... ok
test commands::split_by::tests::splits_inner_tables_by_key ... ok
test utils::data_processing::tests::evaluates_the_tables ... ok
test utils::data_processing::tests::evaluates_the_tables_with_custom_evaluator ... ok
test utils::data_processing::tests::show_columns_sorted_given_a_column_to_sort_by ... ok
test utils::tests::prepares_and_decorates_filesystem_source_files ... ok
test utils::tests::recognizes_if_path_exists_in_value_filesystemlike_sources ... ok
test utils::tests::prepares_and_decorates_value_filesystemlike_sources ... ok
test utils::data_processing::tests::maps_and_gets_max_value ... ok
test utils::data_processing::tests::reducer_computes ... ok
test utils::data_processing::tests::sorts_the_tables ... ok

test result: ok. 53 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out

     Running target/debug/deps/nu-de128195be4d7dd3

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out

     Running target/debug/deps/nu_plugin_core_inc-29be43307742aee1

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out

     Running target/debug/deps/nu_plugin_core_ps-d12dc30b1a6d8de9

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out

     Running target/debug/deps/nu_plugin_core_str-a4e1276478fbdfbd

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out

     Running target/debug/deps/nu_plugin_core_sys-6af401489aedc31f

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out

     Running target/debug/deps/nu_plugin_core_textview-e28879dbd9a63847

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out

     Running target/debug/deps/main-412fcf323af323e6

running 162 tests
test commands::cd::filesystem_change_to_a_directory_containing_spaces ... ok
test commands::cd::filesystem_change_current_directory_to_parent_directory ... ok
test commands::cd::filesystem_change_from_current_directory_using_relative_path ... ok
test commands::cd::filesystem_directory_not_found ... ok
test commands::cd::filesystem_not_a_directory ... ok
test commands::cd::filesystem_change_to_home_directory ... ok
test commands::cd::filesystem_change_from_current_directory_using_absolute_path ... ok
test commands::append::adds_a_row_to_the_end ... ok
test commands::cd::filesystem_switch_back_to_previous_working_directory ... ok
test commands::cd::valuesystem_change_from_current_path_using_absolute_path ... ok
test commands::cd::filesytem_change_from_current_directory_using_relative_path_and_dash ... ok
test commands::cd::valuesystem_change_to_a_path_containing_spaces ... ok
test commands::cd::valuesystem_change_current_path_to_parent_path ... ok
test commands::cd::valuesystem_change_from_current_path_using_relative_path ... ok
test commands::cd::valuesystem_change_from_current_path_using_relative_path_and_dash ... ok
test commands::cd::valuesystem_change_to_home_directory ... ok
test commands::cd::valuesystem_path_not_found ... ok
test commands::cd::valuesystem_switch_back_to_previous_working_path ... ok
test commands::compact::discards_empty_rows_by_default ... ok
test commands::cp::copies_the_file_inside_directory_if_path_to_copy_is_directory ... ok
test commands::cp::copies_the_directory_inside_directory_if_path_to_copy_is_directory_and_with_recursive_flag ... ok
test commands::cp::copies_using_a_glob ... ok
test commands::cp::copies_a_file ... ok
test commands::compact::discards_rows_where_given_column_is_empty ... ok
test commands::cp::copies_using_path_with_wildcard ... ok
test commands::cp::deep_copies_with_recursive_flag ... ok
test commands::enter::errors_if_file_not_found ... ok
test commands::cp::error_if_attempting_to_copy_a_directory_to_another_directory ... ok
test commands::edit::creates_a_new_table_with_the_new_row_given ... ok
test commands::first::gets_all_rows_if_amount_higher_than_all_rows ... ok
test commands::default::adds_row_data_if_column_missing ... ok
test commands::first::gets_first_row_when_no_amount_given ... ok
test commands::enter::knows_the_filesystems_entered ... ok
test commands::first::gets_first_rows_by_amount ... ok
test commands::format::creates_the_resulting_string_from_the_given_fields ... ok
test commands::get::errors_fetching_by_column_using_a_number ... ok
test commands::get::column_paths_are_either_double_quoted_or_regular_unquoted_words_separated_by_dot ... ok
test commands::get::errors_fetching_by_column_not_present ... ok
test commands::get::errors_fetching_by_index_out_of_bounds ... ok
test commands::get::fetches_a_row ... ok
test commands::get::fetches_by_column_path ... ok
test commands::get::fetches_by_index ... ok
test commands::group_by::errors_if_given_unknown_column_name_is_missing ... ok
test commands::group_by::groups ... ok
test commands::get::fetches_more_than_one_column_path ... ok
test commands::last::gets_last_row_when_no_amount_given ... ok
test commands::insert::insert_plugin ... ok
test commands::last::gets_last_rows_by_amount ... ok
test commands::histogram::summarizes ... ok
test commands::last::gets_the_last_row ... ok
test commands::ls::lists_regular_files ... ok
test commands::ls::lists_all_files_in_directories_from_stream ... ok
test commands::ls::lists_regular_files_using_asterisk_wildcard ... ok
test commands::mkdir::creates_directory ... ok
test commands::mkdir::accepts_and_creates_directories ... ok
test commands::ls::lists_regular_files_using_question_mark_wildcard ... ok
test commands::lines::lines ... ok
test commands::mv::moves_a_directory ... ok
test commands::mkdir::creates_intermediary_directories ... ok
test commands::mv::moves_a_file ... ok
test commands::mv::moves_the_file_inside_directory_if_path_to_move_is_existing_directory ... ok
test commands::mv::moves_using_a_glob ... ok
test commands::mv::moves_the_directory_inside_directory_if_path_to_move_is_existing_directory ... ok
test commands::mv::moves_the_directory_inside_directory_if_path_to_move_is_nonexistent_directory ... ok
test commands::mv::moves_using_path_with_wildcard ... ok
test commands::mv::overwrites_if_moving_to_existing_file ... ok
test commands::open::errors_if_file_not_found ... ok
test commands::open::parses_bson ... ok
test commands::open::parses_ini ... ok
test commands::open::parses_csv ... ok
test commands::open::parses_json ... ok
test commands::open::parses_toml ... ok
test commands::open::parses_sqlite ... ok
test commands::open::parses_tsv ... ok
test commands::open::parses_more_bson_complexity ... ok
test commands::open::parses_utf16_ini ... ok
test commands::parse::extracts_fields_from_the_given_the_pattern ... ok
test commands::open::parses_xml ... ok
test commands::pick::allows_if_given_unknown_column_name_is_missing ... ok
test commands::pick::regular_columns ... ok
test commands::prepend::adds_a_row_to_the_beginning ... ok
test commands::pick::complex_nested_columns ... ok
test commands::range::selects_a_row ... ok
test commands::range::selects_some_rows ... ok
test commands::reverse::can_get_reverse_first ... ok
test commands::rm::errors_if_attempting_to_delete_a_directory_with_content_without_recursive_flag ... ok
test commands::rm::errors_if_attempting_to_delete_two_dot_as_argument ... ok
test commands::rm::removes_a_file ... ok
test commands::rm::errors_if_attempting_to_delete_single_dot_as_argument ... ok
test commands::rm::removes_directory_contents_with_recursive_flag ... ok
test commands::rm::removes_deeply_nested_directories_with_wildcard_and_recursive_flag ... ok
test commands::rm::removes_directory_contents_without_recursive_flag_if_empty ... ok
test commands::rm::removes_files_with_wildcard ... ok
test commands::save::figures_out_intelligently_where_to_write_out_with_metadata ... ok
test commands::save::writes_out_csv ... ok
test commands::sort_by::sort_primitive_values ... ok
test commands::split_by::errors_if_no_table_given_as_input ... ok
test commands::split_by::splits ... ok
test commands::uniq::removes_duplicate_rows ... ok
test commands::sort_by::by_column ... ok
test commands::uniq::nested_json_structures ... ok
test commands::split_column::by_column ... ok
test commands::uniq::uniq_when_keys_out_of_order ... ok
test commands::uniq::uniq_values ... ok
test commands::wrap::wrap_rows_into_a_row ... ok
test commands::wrap::wrap_rows_into_a_table ... ok
test format_conversions::bson::table_to_bson_and_back_into_table ... ok
test format_conversions::csv::from_csv_text_to_table ... ok
test format_conversions::csv::from_csv_text_skipping_headers_to_table ... ok
test commands::where_::filters_by_unit_size_comparison ... ok
test commands::where_::contains_operator ... ok
test format_conversions::csv::from_csv_text_with_separator_to_table ... ok
test format_conversions::csv::table_to_csv_text_and_from_csv_text_back_into_table ... ok
test format_conversions::csv::table_to_csv_text_skipping_headers_after_conversion ... ok
test format_conversions::csv::table_to_csv_text ... ok
test format_conversions::json::from_json_text_recognizing_objects_independently_to_table ... ok
test format_conversions::csv::from_csv_text_with_tab_separator_to_table ... ok
test format_conversions::json::from_json_text_to_table ... ok
test format_conversions::json::table_to_json_text_and_from_json_text_back_into_table ... ok
test format_conversions::ssv::from_ssv_text_to_table ... ok
test format_conversions::sqlite::table_to_sqlite_and_back_into_table ... ok
test format_conversions::json::table_to_json_text ... ok
test format_conversions::ssv::from_ssv_text_to_table_with_separator_specified ... ok
test format_conversions::toml::table_to_toml_text_and_from_toml_text_back_into_table ... ok
test format_conversions::tsv::from_tsv_text_skipping_headers_to_table ... ok
test format_conversions::tsv::from_tsv_text_to_table ... ok
test format_conversions::ssv::from_ssv_text_treating_first_line_as_data_with_flag ... ok
test format_conversions::tsv::table_to_tsv_text ... ok
test format_conversions::tsv::table_to_tsv_text_and_from_tsv_text_back_into_table_using_csv_separator ... ok
test format_conversions::tsv::table_to_tsv_text_and_from_tsv_text_back_into_table ... ok
test format_conversions::tsv::table_to_tsv_text_skipping_headers_after_conversion ... ok
test format_conversions::url::can_encode_and_decode_urlencoding ... ok
test format_conversions::ods::from_ods_file_to_table ... ok
test commands::where_::binary_operator_comparisons ... ok
test format_conversions::yaml::table_to_yaml_text_and_from_yaml_text_back_into_table ... ok
test plugins::core_inc::can_only_apply_one ... ok
test plugins::core_inc::by_one_with_no_field_passed ... ok
test plugins::core_inc::by_one_with_field_passed ... ok
test format_conversions::xlsx::from_excel_file_to_table ... ok
test plugins::core_inc::semversion_minor_inc ... ok
test plugins::core_inc::semversion_patch_inc ... ok
test plugins::core_inc::semversion_without_passing_field ... ok
test plugins::core_str::can_only_apply_one ... ok
test plugins::core_inc::semversion_major_inc ... ok
test plugins::core_str::acts_without_passing_field ... ok
test plugins::core_str::downcases ... ok
error: Command not found
- shell:1:35
1 |         cococo joturner@foo.bar.baz
  |         ^^^^^^ command not found
test plugins::core_str::converts_to_int ... ok
test plugins::core_str::find_and_replaces ... ok
test plugins::core_str::replaces ... ok
test plugins::core_str::find_and_replaces_without_passing_field ... ok
test shell::pipeline::commands::external::external_words::relaxed_external_words ... FAILED
error: Command not found
- shell:1:93
1 |                             open nu_candies.txt | lines | chop $it | lines | nth 1 | echo $it
  |                                                           ^^^^ command not found
test shell::pipeline::commands::external::it_evaluation::takes_rows_of_nu_value_lines ... FAILED
test plugins::core_str::upcases ... ok
error: Command not found
- shell:1:20
1 |             cococo ~
  |             ^^^^^^ command not found
test shell::pipeline::commands::external::shows_error_for_command_not_found ... ok
error: Command not found
- test shell::pipeline::commands::external::tilde_expansion::as_home_directory_when_passed_as_argument_and_begins_with_tilde ... ok
shell:1:32
1 |                     cococo "1~1"
  |                     ^^^^^^ command not found
test shell::pipeline::commands::external::tilde_expansion::does_not_expand_when_passed_as_argument_and_does_not_start_with_tilde ... FAILED
error: Command not found
- shell:1:50
1 |                             echo "nushelll" | chop
  |                                               ^^^^ command not found
test shell::pipeline::commands::internal::can_process_one_row_from_internal_and_pipes_it_to_stdin_of_external ... FAILED
error: Command not found
- shell:1:90
1 |                             open nu_times.csv | get name | chop | lines | nth 3 | echo $it
  |                                                            ^^^^ command not found
test shell::pipeline::commands::internal::takes_rows_of_nu_value_strings_and_pipes_it_to_stdin_of_external ... FAILED
error: Command not found
- shell:1:96
1 |                             ls | sort-by name | get name | cococo $it | lines | nth 1 | echo $it
  |                                                            ^^^^^^ command not found
test shell::pipeline::commands::external::it_evaluation::takes_rows_of_nu_value_strings ... FAILED
test shell::pipeline::commands::internal::tilde_expansion::as_home_directory_when_passed_as_argument_and_begins_with_tilde ... ok
test shell::pipeline::doesnt_break_on_utf8 ... ok
test shell::pipeline::commands::internal::tilde_expansion::does_not_expand_when_passed_as_argument_and_does_not_start_with_tilde ... ok

failures:

---- shell::pipeline::commands::external::external_words::relaxed_external_words stdout ----
=== stderr

thread 'shell::pipeline::commands::external::external_words::relaxed_external_words' panicked at 'assertion failed: `(left == right)`
  left: `""`,
 right: `"joturner@foo.bar.baz"`', tests/shell/pipeline/commands/external.rs:90:9
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.

---- shell::pipeline::commands::external::it_evaluation::takes_rows_of_nu_value_lines stdout ----
=== stderr

thread 'shell::pipeline::commands::external::it_evaluation::takes_rows_of_nu_value_lines' panicked at 'assertion failed: `(left == right)`
  left: `""`,
 right: `"AndrásWithKitKat"`', tests/shell/pipeline/commands/external.rs:76:13

---- shell::pipeline::commands::external::tilde_expansion::does_not_expand_when_passed_as_argument_and_does_not_start_with_tilde stdout ----
=== stderr

thread 'shell::pipeline::commands::external::tilde_expansion::does_not_expand_when_passed_as_argument_and_does_not_start_with_tilde' panicked at 'assertion failed: `(left == right)`
  left: `""`,
 right: `"1~1"`', tests/shell/pipeline/commands/external.rs:121:9

---- shell::pipeline::commands::internal::can_process_one_row_from_internal_and_pipes_it_to_stdin_of_external stdout ----
=== stderr

thread 'shell::pipeline::commands::internal::can_process_one_row_from_internal_and_pipes_it_to_stdin_of_external' panicked at 'assertion failed: `(left == right)`
  left: `""`,
 right: `"nushell"`', tests/shell/pipeline/commands/internal.rs:42:5

---- shell::pipeline::commands::internal::takes_rows_of_nu_value_strings_and_pipes_it_to_stdin_of_external stdout ----
=== stderr

thread 'shell::pipeline::commands::internal::takes_rows_of_nu_value_strings_and_pipes_it_to_stdin_of_external' panicked at 'assertion failed: `(left == right)`
  left: `""`,
 right: `"AndKitKat"`', tests/shell/pipeline/commands/internal.rs:31:9

---- shell::pipeline::commands::external::it_evaluation::takes_rows_of_nu_value_strings stdout ----
=== stderr

thread 'shell::pipeline::commands::external::it_evaluation::takes_rows_of_nu_value_strings' panicked at 'assertion failed: `(left == right)`
  left: `""`,
 right: `"jonathan_likes_cake.txt"`', tests/shell/pipeline/commands/external.rs:49:13


failures:
    shell::pipeline::commands::external::external_words::relaxed_external_words
    shell::pipeline::commands::external::it_evaluation::takes_rows_of_nu_value_lines
    shell::pipeline::commands::external::it_evaluation::takes_rows_of_nu_value_strings
    shell::pipeline::commands::external::tilde_expansion::does_not_expand_when_passed_as_argument_and_does_not_start_with_tilde
    shell::pipeline::commands::internal::can_process_one_row_from_internal_and_pipes_it_to_stdin_of_external
    shell::pipeline::commands::internal::takes_rows_of_nu_value_strings_and_pipes_it_to_stdin_of_external

test result: FAILED. 156 passed; 6 failed; 0 ignored; 0 measured; 0 filtered out

error: test failed, to rerun pass '--test main'
builder for '/nix/store/7cgclnbja0n06alfzj5pabixqlwykznh-nushell-0.9.0.drv' failed with exit code 101
error: build of '/nix/store/7cgclnbja0n06alfzj5pabixqlwykznh-nushell-0.9.0.drv' failed

checks ofborg ... oh. Guess we knew that 😛

@evanjs
Copy link
Member

evanjs commented Jan 30, 2020

FWIW, the same tests fail from a normal cargo build from the nushell repository@0.9.0.

@evanjs
Copy link
Member

evanjs commented Jan 30, 2020

A little further with
checkPhase = stdenv.lib.optional withStableFeatures "cargo test --features=stable";

output from build 
running 53 tests
test commands::classified::external::tests::adds_quotes_to_argument_to_be_passed_in ... ok
test commands::classified::external::tests::checks_contains_whitespace_from_argument_to_be_passed_in ... ok
test commands::classified::external::tests::does_not_expand_tilde_if_tilde_is_not_first_character ... ok
test commands::classified::external::tests::checks_quotes_from_argument_to_be_passed_in ... ok
test commands::classified::external::tests::expands_tilde_if_starts_with_tilde_character ... ok
test commands::classified::external::tests::strips_quotes_from_argument_to_be_passed_in ... ok
test commands::from_ssv::tests::it_deals_with_single_column_input ... ok
test commands::from_ssv::tests::it_allows_a_predefined_number_of_spaces ... ok
test commands::from_ssv::tests::it_trims_empty_and_whitespace_only_lines ... ok
test commands::from_ssv::tests::it_trims_remaining_separator_space ... ok
test commands::from_ssv::tests::it_keeps_empty_columns ... ok
test commands::classified::external::tests::identifies_command_not_found ... ok
test commands::from_ssv::tests::it_uses_the_full_final_column ... ok
test commands::from_ssv::tests::it_returns_none_given_an_empty_string ... ok
test commands::from_ssv::tests::it_uses_first_row_as_data_when_headerless ... ok
test commands::from_ssv::tests::it_handles_empty_values_when_headerless_and_aligned_columns ... ok
test commands::from_xml::tests::parses_empty_element ... ok
test commands::from_xml::tests::parses_element_with_attribute ... ok
test commands::from_xml::tests::parses_element_with_text ... ok
test commands::from_xml::tests::parses_element_with_multiple_attributes ... ok
test commands::from_xml::tests::parses_element_with_attribute_and_element ... ok
test commands::from_ssv::tests::input_is_parsed_correctly_if_either_option_works ... ok
test commands::from_xml::tests::parses_element_with_elements ... ok
test data::base::tests::gets_matching_field_from_a_row ... ok
test data::base::tests::gets_matching_field_from_nested_rows_inside_a_row ... ok
test data::base::tests::gets_first_matching_field_from_rows_with_same_field_inside_a_table ... ok
test deserializer::tests::check_type_name_properties ... ok
test data::base::tests::column_path_that_contains_just_a_number_gets_a_row_from_a_row ... ok
test commands::split_by::tests::errors_if_key_within_some_inner_table_is_missing ... ok
test commands::group_by::tests::groups_table_by_country_column ... ok
test data::base::tests::replaces_matching_field_from_a_row ... ok
test data::base::tests::replaces_matching_field_from_nested_rows_inside_a_row ... ok
test data::base::tests::column_path_that_contains_just_a_number_gets_a_row_from_a_table ... ok
test utils::data_processing::tests::evaluator_fetches_by_column_if_supplied_a_column_name ... ok
test data::base::tests::replaces_matching_field_from_rows_inside_a_table ... ok
test utils::data_processing::tests::evaluator_returns_1_if_no_column_name_given ... ok
test commands::group_by::tests::groups_table_by_date_column ... ok
test env::environment::tests::picks_up_path_variables_from_configuration ... ok
test utils::data_processing::tests::reducer_computes_given_a_sum_command ... ok
test env::environment::tests::picks_up_environment_variables_from_configuration ... ok
test utils::tests::prepares_and_decorates_value_filesystemlike_sources ... ok
test env::environment::tests::does_not_update_env_variable_if_it_exists ... FAILED
test env::environment::tests::updates_path_variable ... FAILED
test env::environment::tests::updates_env_variable ... FAILED
test utils::tests::prepares_and_decorates_filesystem_source_files ... ok
test utils::data_processing::tests::show_columns_sorted_given_a_column_to_sort_by ... ok
test utils::tests::recognizes_if_path_exists_in_value_filesystemlike_sources ... ok
test commands::split_by::tests::splits_inner_tables_by_key ... ok
test utils::data_processing::tests::reducer_computes ... ok
test utils::data_processing::tests::maps_and_gets_max_value ... ok
test utils::data_processing::tests::evaluates_the_tables_with_custom_evaluator ... ok
test utils::data_processing::tests::evaluates_the_tables ... ok
test utils::data_processing::tests::sorts_the_tables ... ok

failures:

---- env::environment::tests::does_not_update_env_variable_if_it_exists stdout ----
thread 'env::environment::tests::does_not_update_env_variable_if_it_exists' panicked at 'assertion failed: `(left == right)`
  left: `Some(Value { value: Row(Dictionary { entries: {"SHELL": Value { value: Primitive(String("/usr/bin/sh")), tag: Tag { anchor: None, span: Span { start: 0, end: 0 } } }} }), tag: Tag { anchor: None, span: Span { start: 0, end: 0 } } })`,
 right: `Some(Value { value: Row(Dictionary { entries: {"SHELL": Value { value: Primitive(String("/usr/bin/you_already_made_the_nu_choice")), tag: Tag { anchor: None, span: Span { start: 0, end: 0 } } }} }), tag: Tag { anchor: None, span: Span { start: 0, end: 0 } } })`', src/env/environment.rs:246:13

---- env::environment::tests::updates_path_variable stdout ----
thread 'env::environment::tests::updates_path_variable' panicked at 'assertion failed: `(left == right)`
  left: `Some(Value { value: Table([Value { value: Primitive(String("/path/to/be/added")), tag: Tag { anchor: None, span: Span { start: 0, end: 0 } } }]), tag: Tag { anchor: None, span: Span { start: 0, end: 0 } } })`,
 right: `Some(Value { value: Table([Value { value: Primitive(String("/path/to/be/added")), tag: Tag { anchor: None, span: Span { start: 0, end: 0 } } }, Value { value: Primitive(String("/Users/andresrobalino/.volta/bin")), tag: Tag { anchor: None, span: Span { start: 0, end: 0 } } }, Value { value: Primitive(String("/users/mosqueteros/bin")), tag: Tag { anchor: None, span: Span { start: 0, end: 0 } } }]), tag: Tag { anchor: None, span: Span { start: 0, end: 0 } } })`', src/env/environment.rs:277:13
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.

---- env::environment::tests::updates_env_variable stdout ----
thread 'env::environment::tests::updates_env_variable' panicked at 'assertion failed: `(left == right)`
  left: `Some(Value { value: Row(Dictionary { entries: {"USER": Value { value: Primitive(String("NUNO")), tag: Tag { anchor: None, span: Span { start: 0, end: 0 } } }} }), tag: Tag { anchor: None, span: Span { start: 0, end: 0 } } })`,
 right: `Some(Value { value: Row(Dictionary { entries: {"USER": Value { value: Primitive(String("NUNO")), tag: Tag { anchor: None, span: Span { start: 0, end: 0 } } }, "SHELL": Value { value: Primitive(String("/usr/bin/you_already_made_the_nu_choice")), tag: Tag { anchor: None, span: Span { start: 0, end: 0 } } }} }), tag: Tag { anchor: None, span: Span { start: 0, end: 0 } } })`', src/env/environment.rs:213:13


failures:
    env::environment::tests::does_not_update_env_variable_if_it_exists
    env::environment::tests::updates_env_variable
    env::environment::tests::updates_path_variable

test result: FAILED. 50 passed; 3 failed; 0 ignored; 0 measured; 0 filtered out

error: test failed, to rerun pass '--lib'
builder for '/nix/store/qz76mq95bynhfd4r407a19i8gj1dhny4-nushell-0.9.0.drv' failed with exit code 101
error: build of '/nix/store/qz76mq95bynhfd4r407a19i8gj1dhny4-nushell-0.9.0.drv' failed

@cust0dian-old cust0dian-old marked this pull request as ready for review January 30, 2020 11:17
@cust0dian-old
Copy link
Contributor Author

@filalex77 sorry to re-request your review: like @evanjs mentions above, just bumping version broke the tests since test binaries where moved to a separate cargo feature and I didn't notice it straight away.

Could you, please, ask OfBorg for a build so a Darwin builder builds it too? It built without issues on my OSX machine but double-checking would be nice.

cust0dian-old
cust0dian-old commented Jan 30, 2020
View reviewed changes
pkgs/shells/nushell/default.nix

preCheck = ''
export HOME=$TMPDIR
'';

meta = with stdenv.lib; {
checkPhase = ''
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently there doesn't seem to be a way to pass options to cargo test itself, only to the tested binary via checkFlags.

I've introduced a checkPhase override here since it's less invasive change, but maybe buildRustPackage should allow passing those options instead?

cc @andir (sorry for the ping, but you are listed as a codeowner there so I wanted to get it on your radar)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checkPhase override is the only way for now, so it can stay.

@Br1ght0ne
Copy link
Member

No worries, ask me anytime. I'm puzzled as to why my build passed all tests, but I'll check that later.

As you requested, starting a Darwin build.
@GrahamcOfBorg build nushell

@evanjs
Copy link
Member

evanjs commented Jan 31, 2020

Builds and runs fine on NixOS now.
Thank you!

@Ma27 Ma27 merged commit 4afad26 into NixOS:master Feb 1, 2020
@cust0dian-old cust0dian-old deleted the nushell-0.9.0 branch February 1, 2020 11:43
anna328p pushed a commit to anna328p/nixpkgs that referenced this pull request Feb 2, 2020
@Ma27 @anna328p
Merge pull request NixOS#78782 from cust0dian/nushell-0.9.0
d546d9c 
nushell: 0.8.0 -> 0.9.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marsam marsam Awaiting requested review from marsam

@Br1ght0ne Br1ght0ne Awaiting requested review from Br1ght0ne

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@cust0dian-old @evanjs @Br1ght0ne @Ma27 @cust0dian