Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dwarf-fortress-packages.dwarf-fortress_0_47_01: init #78901

Merged
merged 3 commits into from Feb 3, 2020
Merged

dwarf-fortress-packages.dwarf-fortress_0_47_01: init #78901

merged 3 commits into from Feb 3, 2020

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Jan 30, 2020 •
edited

Motivation for this change

until dfhack has support for the latest release, I'm not going to bump dwarf-fortress default.

However, you should be able to do dwarf-fortress-packages.dwarf-fortress_0_47_01 and play the game.

closes: #78791

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@shazow
Copy link
Contributor

shazow commented Jan 31, 2020

Confirmed that this works for me (on NixOS). Thank you!

@shazow
Copy link
Contributor

shazow commented Jan 31, 2020

Btw, we could also update some of the themes. Here's pheobus which I use:

diff --git a/pkgs/games/dwarf-fortress/themes/themes.json b/pkgs/games/dwarf-fortress/themes/themes.json
index f2cc4ed3ac7..f4c47cce372 100644
--- a/pkgs/games/dwarf-fortress/themes/themes.json
+++ b/pkgs/games/dwarf-fortress/themes/themes.json
@@ -26,8 +26,8 @@
   },
   {
       "name": "phoebus",
-      "version": "44.10",
-      "sha256": "1fvl5251wzjns159snhw01p214k53vpdlyj7piv545r23q7wg2ji"
+      "version": "47.01",
+      "sha256": "1rf47p6a4f6scpzlmy9q3v1pakdjs06f9aingajpaia44lmjdfn6"
   },
   {
       "name": "obsidian",

Happy to make a separate PR if that's easier, let me know.

tomberek
tomberek approved these changes Feb 2, 2020
View reviewed changes
Copy link
Contributor

@tomberek tomberek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds and runs on NixOS. Losing is fun.

@shazow shazow mentioned this pull request Feb 2, 2020
Merged
10 tasks
@jonringer
Copy link
Contributor Author

I was able to build and run the programs, and it appears others have tested.

@jonringer jonringer merged commit e293cf9 into NixOS:master Feb 3, 2020
@jonringer
Copy link
Contributor Author

@shazow @tomberek thanks for the reviews!

@jonringer jonringer deleted the bump-dwarf-fortress branch February 3, 2020 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomberek tomberek tomberek approved these changes

@the-kenny the-kenny Awaiting requested review from the-kenny

@abbradar abbradar Awaiting requested review from abbradar

@bendlas bendlas Awaiting requested review from bendlas

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dwarf Fortress Package is vastly behind, update.sh just creates empty game.json file
3 participants
@jonringer @shazow @tomberek