Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/duosec: fix configuration issue with "groups" option #78902

Merged
merged 1 commit into from Jan 31, 2020

Conversation

aanderse
Copy link
Member

@aanderse aanderse commented Jan 30, 2020

Motivation for this change

There is a bug in this module rendering the group option useless. The option is called groups. Oops!

See https://duo.com/docs/duounix for details.

Things done

Absolutely nothing, I don't run this software

ping @sdier, @reanimus, and @thoughtpolice (maybe stretching with this one...) for possible review and possible testing.

Copy link
Contributor

@sdier sdier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this. I won't have time to test this (my development machine is down for a few days waiting on new parts) but it appears correct.

@aanderse
Copy link
Member Author

@sdier thanks!

@aanderse aanderse merged commit bf348f0 into NixOS:master Jan 31, 2020
@aanderse aanderse deleted the duo-unix branch January 31, 2020 19:19
anna328p pushed a commit to anna328p/nixpkgs that referenced this pull request Feb 2, 2020
nixos/duosec: fix configuration issue with "groups" option
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants