Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

highfive: init at 2.1.1 #78915

Closed
wants to merge 1 commit into from
Closed

highfive: init at 2.1.1 #78915

wants to merge 1 commit into from

Conversation

robertodr
Copy link
Contributor

Motivation for this change

Add the HighFive header-only C++ HDF5 interface.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

jonringer
jonringer approved these changes Jan 31, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM

[4 built, 11 copied (25.9 MiB), 6.7 MiB DL]
https://github.com/NixOS/nixpkgs/pull/78915
2 package built:
highfive highfive-mpi

pkgs/development/libraries/highfive/default.nix Show resolved Hide resolved
@jonringer
Copy link
Contributor

do you mind squashing?

git reset HEAD^
git add pkgs/
git commit --amend --no-edit
git push .. .. --force

@kouk @robertodr
kops: 1.15.0 -> 1.15.1 (NixOS#78821)
4c806dc 
Upgrade the kops_1_15 attribute of kops to bring in the newest patch release (1.15.1) which includes many important bug fixes.
Full release notes here: https://github.com/kubernetes/kops/releases/tag/v1.15.1
@robertodr
Copy link
Contributor Author

robertodr commented Jan 31, 2020 •
edited

I think I FUBAR-ed the rebase 😅 Should I open a new PR?

@robertodr robertodr mentioned this pull request Jan 31, 2020
Merged
10 tasks
@robertodr
Copy link
Contributor Author

Redone cleanly in #78947 Apologies for the noise and confusion!

@robertodr robertodr closed this Jan 31, 2020
@robertodr robertodr deleted the add-highfive branch January 31, 2020 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@robertodr @jonringer @kouk