common-updater-scripts: Support SRI-style hash #78913
Merged
+54
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is SRI already allowed in Nixpkgs? If I am correct it's a Nix |
|
See 267c8d6 |
ofborg
bot
added
10.rebuild-darwin: 0
worldofpeace
reviewed
Feb 4, 2020
Some fetcher functions support SRI-style `hash` attribute in addition to legacy type-specific attributes. When `hash` is used `outputHashAlgo` is null so let’s complain when SRI-style hash value was not detected.
Such attributes match the form ${type}${separator}${hash}: True SRI uses dash as a separator and only supports base64, whereas Nix’s SRI-style format uses a colon and supports all the same encodings like regular hashes (16/32/64).
To keep this program reasonably simple, we will upgrade Nix’s SRI-like format to pure SRI instead of preserving it.
Fix issues reported by shellcheck and few other style issues. Though we need to ignore $systemArg complaints because Nix does not support passing --system as a single argument.
We can check some things before the modifications take place.
dtzWill
pushed a commit
to dtzWill/nixpkgs
that referenced
this pull request
Feb 5, 2020
common-updater-scripts: Support SRI-style hash (cherry picked from commit f40a8a0)
|
Thanks for adding this @jtojnar |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some fetcher functions support SRI-style
hashattribute in addition to legacy type-specific attributes. Whenhashis usedoutputHashAlgois null so let’s complain when SRI-style hash value was not detected.Such attributes match the form
${type}${separator}${hash}: True SRI uses dash as a separator and only supports base64, whereas Nix’s SRI-style format uses a colon and supports all the same encodings like regular hashes (16/32/64).To keep this program reasonably simple, we will upgrade Nix’s SRI-like format to pure SRI instead of preserving it.
Relevant code: