pythonPackages.docloud: init at 1.0.375 #78874
Conversation
drewrisinger
force-pushed
the
dr-pr-python-docloud
branch
from
2c07bdc
to
9d39afa
Compare
The IBM Decision Optimization on Cloud Python client. Requirement of docplex, which is a dependency of qiskit-aqua.
drewrisinger
force-pushed
the
dr-pr-python-docloud
branch
from
9d39afa
to
71ec410
Compare
There was a problem hiding this comment.
not going to lie, this package is "smelly":
- versioning looks like incremental releases
- no tests
I guess the dependency list is small and stable. But I'm not really convinced this belongs in nixpkgs.
Looking at the example for qiskit (which is the end goal), it's meant to be consumed as an sdk, which means it will have to play well with the rest of t he python-ecosystem.
My main concern is that the nixpkgs python ecosystem (which has a pretty fast and steady cadence), may make this really fragile (E.g, one of the new 27 dependencies is broken, now it's broken too).
If you're willing to be active and maintain these package set I'll be cooperative in getting it in, but generally it's the case that the core contributors take the lion share of having to maintain these packages.
For example, the google package set right now has namespace issues so it's horribly broken at the moment. But I don't have the time or cares to fix it, and the original maintainer is longer able to be found.
|
Fair. Thanks for your help with this whole process. It looks like the qiskit-aqua package will be broken then without the qiskit-aqua -> docplex -> docloud dependency, as the docplex dependency is pretty deep, e.g. covered in the README. ising/docplex.py and test_readme_sample.py. If I can't get the entire |
There was a problem hiding this comment.
diff LGTM (would still like tests)
trusting @drewrisinger to help maintain these packages :)
[5 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/78874
3 package built:
python27Packages.docloud python37Packages.docloud python38Packages.docloud
Motivation for this change
Add sub-dependency for upcoming package qiskit-aqua #78772 @jonringer
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)