Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.pylatexenc: init at 2.1 #78878

Merged
merged 1 commit into from Feb 19, 2020
Merged

pythonPackages.pylatexenc: init at 2.1 #78878

merged 1 commit into from Feb 19, 2020

Conversation

drewrisinger
Copy link
Contributor

Motivation for this change

Add dependency for upcoming qiskit package #78772 @jonringer

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@drewrisinger
Copy link
Contributor Author

@GrahamcOfBorg build python3Packages.pylatexenc

@drewrisinger
Copy link
Contributor Author

@GrahamcOfBorg build python3Packages.pylatexenc

@drewrisinger
pythonPackages.pylatexenc: init at 2.1
6ee5dea 
Latex converter for Python.
Check dependency of qiskit.
@drewrisinger drewrisinger mentioned this pull request Feb 18, 2020
Merged
10 tasks
@drewrisinger
Copy link
Contributor Author

@jonringer This is a simple PR, fully tested. No smells like the #78874 #78875 (docloud/docplex) ones. This is the only remaining dependency for #80464, which is similarly fully tested and should be mergeable.

@drewrisinger
Copy link
Contributor Author

@GrahamcOfBorg build python27Packages.pylatexenc python37Packages.pylatexenc python38Packages.pylatexenc

jonringer
jonringer approved these changes Feb 19, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM
commit LGTM
has tests 👍

[5 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/78878
3 package built:
python27Packages.pylatexenc python37Packages.pylatexenc python38Packages.pylatexenc

@jonringer
Copy link
Contributor

@GrahamcOfBorg build python27Packages.pylatexenc python37Packages.pylatexenc python38Packages.pylatexenc

@jonringer jonringer merged commit a26f334 into NixOS:master Feb 19, 2020
@drewrisinger drewrisinger deleted the dr-pr-python-pylatexenc branch February 20, 2020 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@drewrisinger @jonringer