pythonPackages.stestr: init at 2.6.0 #78879
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewrisinger
force-pushed
the
dr-pr-python-stestr
branch
from
2136fc1
to
55bd0ab
Compare
Python Parallel test runner. Used in qiskit tests.
drewrisinger
force-pushed
the
dr-pr-python-stestr
branch
from
55bd0ab
to
d298702
Compare
doronbehar
reviewed
Feb 23, 2020
| ]; | ||
| pythonCheckImports = [ "stestr" ]; | ||
| checkPhase = '' | ||
| export PATH=$out/bin:$PATH # add stestr to path |
There was a problem hiding this comment.
Suggested change
| export PATH=$out/bin:$PATH # add stestr to path | |
| runHook preCheck | |
| export PATH=${placeholder "out"}/bin:$PATH # add stestr to path |
| export HOME=$(mktemp -d) # some tests require home for tempfiles | ||
| stestr init # for test_load.py | ||
| pytest \ | ||
| --ignore-glob='**/test_sql.py' # requires subunit2sql |
There was a problem hiding this comment.
Suggested change
| --ignore-glob='**/test_sql.py' # requires subunit2sql | |
| --ignore-glob='**/test_sql.py' # requires subunit2sql | |
| runHook postCheck |
| voluptuous | ||
| ]; | ||
|
|
||
| # remove test requirements that aren't in Nix. |
There was a problem hiding this comment.
Suggested change
| # remove test requirements that aren't in Nix. | |
| # remove test requirements that aren't in Nix, see checkPhase. |
| @@ -5929,6 +5929,10 @@ in { | |||
|
|
|||
| python_statsd = callPackage ../development/python-modules/python_statsd { }; | |||
|
|
|||
| stestr = callPackage ../development/python-modules/stestr { | |||
| pythonSubunit = self.subunit; | |||
There was a problem hiding this comment.
What happens if you just import at the derivation's header subunit?
| @@ -0,0 +1,73 @@ | |||
| { lib | |||
| , pythonOlder | |||
There was a problem hiding this comment.
Not used in any input or what so ever.
Suggested change
| , pythonOlder |
|
@doronbehar I'm OK with letting this PR lapse, but thanks for your review. I'd originally thought several packages needed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Add test dependency for qiskit #78772 @jonringer
Depends on #78876 and #78877
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)