Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.docplex: init at 2.12.182 #78875

Merged
merged 1 commit into from Feb 19, 2020
Merged

pythonPackages.docplex: init at 2.12.182 #78875

merged 1 commit into from Feb 19, 2020

Conversation

drewrisinger
Copy link
Contributor

Motivation for this change

Add dependency for upcoming package qiskit-aqua #78772 @jonringer
Depends on #78874

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@drewrisinger
Copy link
Contributor Author

@GrahamcOfBorg build python3Packages.docplex

@drewrisinger
Copy link
Contributor Author

build fails b/c missing docloud. PR #78874 must be approved first

@drewrisinger
Copy link
Contributor Author

Should work now that #78874 has been approved. Builds locally.

@jonringer
Copy link
Contributor

otherwise LGTM

[5 built, 3 copied (0.4 MiB), 0.1 MiB DL]
https://github.com/NixOS/nixpkgs/pull/78875
3 package built:
python27Packages.docplex python37Packages.docplex python38Packages.docplex

@drewrisinger drewrisinger mentioned this pull request Feb 18, 2020
Merged
10 tasks
@drewrisinger
pythonPackages.docplex: init at 2.12.182
cc4cc72 
The IBM Decision Optimization CPLEX Modeling for Python.

Dependency of qiskit-aqua.
@drewrisinger
Copy link
Contributor Author

@GrahamcOfBorg build python37Packages.docplex python38Packages.docplex

@FRidh FRidh merged commit ee65cd9 into NixOS:master Feb 19, 2020
@drewrisinger drewrisinger deleted the dr-pr-python-docplex branch February 20, 2020 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer left review comments

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: documentation 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@drewrisinger @jonringer @FRidh