installation-cd-graphical-gnome: updates #78935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtojnar
reviewed
Jan 31, 2020
nixos/modules/installer/cd-dvd/installation-cd-graphical-gnome.nix
Outdated
Show resolved
Hide resolved
nixos/modules/installer/cd-dvd/installation-cd-graphical-gnome.nix
Outdated
Show resolved
Hide resolved
| enable = true; | ||
| user = "root"; | ||
| # This might be problematic on a live system |
There was a problem hiding this comment.
Suspend the machine after inactivity., they could run into the issue with remote connections maybe?
It might be a problem for the installer media to have an incongruent configuration versus someone just using gnome3.enable. But I'm betting if we get the iso we can seed the generated configuration.nix from nixos-install with a comment about this option.
worldofpeace
force-pushed
the
update-gnome3-iso-expression
branch
from
aa2eea4
to
e5b6736
Compare
|
Did you still have any issues with @jtojnar ? |
|
Only that the comments are too vague. They should at least link to the explanation above. |
Note we're not using wayland default in the graphical media because it could cause headaches for Nvidia users. But the session is still available if someone logs out.
worldofpeace
force-pushed
the
update-gnome3-iso-expression
branch
from
e5b6736
to
ad4565c
Compare
|
better Comments added 🤞 . |
jtojnar
approved these changes
Feb 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note we're not using wayland default in the graphical media because it
could cause headaches for Nvidia users. But the session is still available
if someone logs out.
Motivation for this change
This doesn't add it to the release. It's just stuff that I'd like committed that's been languishing around.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)