Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lego: 3.2.0 -> 3.3.0 #78784

Merged
merged 1 commit into from Jan 30, 2020
Merged

lego: 3.2.0 -> 3.3.0 #78784

merged 1 commit into from Jan 30, 2020

Conversation

bbigras
Copy link
Contributor

@bbigras bbigras commented Jan 29, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

/nix/store/p8z4kjs3waay6rr3bir5zjrgp6hlphd2-lego-3.2.0 65.4M
/nix/store/4681rzvznazdximpasasp67rm3kwn0nv-lego-3.3.0 65.5M

With ldflags, lego will show the right version with -v.

I was inspired by:

nixpkgs/pkgs/development/tools/misc/mkcert/default.nix

Lines 17 to 20 in 274d02e

buildFlagsArray = ''
-ldflags=
-X ${goPackagePath}/main.Version=${version}
'';

@ofborg ofborg bot requested review from andrew-d and kalbasit January 29, 2020 22:11
andrew-d
andrew-d suggested changes Jan 29, 2020
View reviewed changes
pkgs/tools/admin/lego/default.nix Outdated Show resolved Hide resolved
@bbigras
Copy link
Contributor Author

bbigras commented Jan 30, 2020

Done. Thanks.

@andrew-d
Copy link
Contributor

@GrahamcOfBorg build lego

@ofborg ofborg bot requested a review from andrew-d January 30, 2020 02:14
andrew-d
andrew-d approved these changes Jan 30, 2020
View reviewed changes
Copy link
Contributor

@andrew-d andrew-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@marsam marsam merged commit d55c1b1 into NixOS:master Jan 30, 2020
@marsam
Copy link
Contributor

marsam commented Jan 30, 2020

Thanks!

@bbigras bbigras deleted the lego branch January 30, 2020 04:29
anna328p pushed a commit to anna328p/nixpkgs that referenced this pull request Feb 2, 2020
@marsam @anna328p
Merge pull request NixOS#78784 from bbigras/lego
6774778 
lego: 3.2.0 -> 3.3.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrew-d andrew-d andrew-d approved these changes

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bbigras @andrew-d @marsam