Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

linuxPackages.wireguard: 0.0.20200121 -> 0.0.20200128 #78726

Merged
merged 1 commit into from Jan 30, 2020
Merged

linuxPackages.wireguard: 0.0.20200121 -> 0.0.20200128 #78726

merged 1 commit into from Jan 30, 2020

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Jan 28, 2020

Motivation for this change

https://lists.zx2c4.com/pipermail/wireguard/2020-January/004905.html

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Ma27 Ma27 added the 9.needs: port to stable A PR needs a backport to the stable release. label Jan 28, 2020
@ofborg ofborg bot requested review from globin, elseym, d-xo and Mic92 January 28, 2020 20:16
d-xo
d-xo approved these changes Jan 28, 2020
View reviewed changes
Copy link
Contributor

@d-xo d-xo left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🐱 ✨

@wamserma
Copy link
Member

@Ma27 From your lnk to the mailing list, this is just a compat update for kernels >= 5.5, so I don't think this requires a backport to stable.

@Ma27
Copy link
Member Author

Ma27 commented Jan 29, 2020

Uhm, it's actually a compat-update for the kernels 3.10 <= Linux <= 5.5.y, as WireGuard has been merged into the kernel and will be released in 5.6.

@wamserma
Copy link
Member

wamserma commented Jan 29, 2020 •
edited

Uhm, it's actually a compat-update for the kernels 3.10 <= Linux <= 5.5.y, as WireGuard has been merged into the kernel and will be released in 5.6.

Yes, but the update 0.0.20200121 -> 0.0.20200128 seems only relevant for systems running a kernel >= 5.5 to avoid conflicts with the modules shipped with the kernel, so this should not affect nixos-19.09.

@Ma27
Copy link
Member Author

Ma27 commented Jan 29, 2020

Ah I guess I misunderstood you. The thing is, we usually backport wireguard versions and I'm not a big fan of skipping versions in that case in general as this means that whoever needs to backport the next version, gets to resolve a merge-conflict.

@wamserma
Copy link
Member

Valid argument. So +1 for a backport from me as I don't expect the update to break anything on stable.

wamserma
wamserma reviewed Jan 29, 2020
View reviewed changes
Copy link
Member

@wamserma wamserma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Ma27 Ma27 merged commit b5da8e8 into NixOS:master Jan 30, 2020
@Ma27 Ma27 deleted the bump-wireguard branch January 30, 2020 15:17
@Ma27
Copy link
Member Author

Ma27 commented Jan 30, 2020

Backported as b1a1ada.

@Ma27 Ma27 added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Jan 30, 2020
anna328p pushed a commit to anna328p/nixpkgs that referenced this pull request Feb 2, 2020
@Ma27 @anna328p
Merge pull request NixOS#78726 from Ma27/bump-wireguard
cacba9d 
linuxPackages.wireguard: 0.0.20200121 -> 0.0.20200128
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wamserma wamserma wamserma left review comments

@d-xo d-xo d-xo approved these changes

@globin globin Awaiting requested review from globin

@elseym elseym Awaiting requested review from elseym

@Mic92 Mic92 Awaiting requested review from Mic92

Assignees
No one assigned
Labels
8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 11-100 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ma27 @wamserma @d-xo