getAnimations from the Document instead of from Timeline #21518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jan 30, 2020
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2024539
branch
5 times, most recently
from
1eb22c5
to
7b06e50
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2024539
branch
7 times, most recently
from
7ce2f8a
to
e789206
Compare
Per the spec, Document::getAnimations() must report all Animations whose target effect is the given document. Spec: https://drafts.csswg.org/web-animations/#extensions-to-the-documentorshadowroot-interface-mixin Bug: 828585 Change-Id: I92a5cab69d0b9869fea0238e2cfb8e98d995a3b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024539 Commit-Queue: Hao Sheng <haozhes@chromium.org> Reviewed-by: Robert Flack <flackr@chromium.org> Reviewed-by: Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#741473}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2024539
branch
from
e789206
to
ac3c7f8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per the spec, Document::getAnimations() must report all Animations whose
target effect is the given document.
Spec:
https://drafts.csswg.org/web-animations/#extensions-to-the-documentorshadowroot-interface-mixin
Bug: 828585
Change-Id: I92a5cab69d0b9869fea0238e2cfb8e98d995a3b9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024539
Commit-Queue: Hao Sheng <haozhes@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Reviewed-by: Kevin Ellis <kevers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#741473}