Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dnscrypt-proxy2: 2.0.36 -> 2.0.38 #78908

Closed
wants to merge 1 commit into from
Closed

dnscrypt-proxy2: 2.0.36 -> 2.0.38 #78908

wants to merge 1 commit into from

Conversation

Atemu
Copy link
Member

@Atemu Atemu commented Jan 30, 2020 •
edited

Motivation for this change

https://github.com/DNSCrypt/dnscrypt-proxy/releases/tag/2.0.38
DNSCrypt/dnscrypt-proxy@d14d2b6

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

bbigras
bbigras approved these changes Jan 30, 2020
View reviewed changes
Copy link
Contributor

@bbigras bbigras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

builds and runs, thanks! 👍

@worldofpeace
Copy link
Contributor

@GrahamcOfBorg build dnscrypt-proxy2

@ofborg ofborg bot requested a review from ehmry January 30, 2020 23:12
@bbigras
Copy link
Contributor

bbigras commented Jan 31, 2020

Another day, another release. 2.0.39 is out.

@Atemu
Copy link
Member Author

Atemu commented Jan 31, 2020

I think I'm gonna wait another day this time...

@Atemu Atemu closed this Jan 31, 2020
@Atemu Atemu deleted the dnscrypt-proxy2-2.0.38 branch July 30, 2020 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbigras bbigras bbigras approved these changes

@ehmry ehmry Awaiting requested review from ehmry

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Atemu @worldofpeace @bbigras