qjournalctl: init at 0.6.2 #78815
Closed
qjournalctl: init at 0.6.2 #78815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Submitted as is. feel free to alprove/reject. |
doronbehar
reviewed
Jan 30, 2020
|
|
||
| meta = with stdenv.lib; { | ||
| description = "Qt-based Graphical User Interface for systemd's journalctl command"; | ||
| homepage = https://github.com/pentix/qjournalctl; |
jtojnar
reviewed
Jul 6, 2020
| ''; | ||
|
|
||
| nativeBuildInputs = [ qmake pkgconfig libssh ]; | ||
| buildInputs = [ qtbase wrapQtAppsHook]; |
There was a problem hiding this comment.
wrapQtAppsHook belongs to nativeBuildInputs.
| substituteInPlace qjournalctl.pro --replace /usr/ $out/ | ||
| ''; | ||
|
|
||
| nativeBuildInputs = [ qmake pkgconfig libssh ]; |
There was a problem hiding this comment.
In new expressions, pkg-config should be used instead of the pkgconfig alias.
There was a problem hiding this comment.
libssh belongs to buildInputs.
| }; | ||
|
|
||
| postPatch = '' | ||
| substituteInPlace qjournalctl.pro --replace /usr/ $out/ |
There was a problem hiding this comment.
It might be nice to have this configurable through makeFlags like here: jamulussoftware/jamulus#247
There was a problem hiding this comment.
I'm trying to pick up this PR. How could this be achieved? By providing a patch for the .pro file?
| qmake, | ||
| pkgconfig, | ||
| libssh, | ||
| wrapQtAppsHook |
There was a problem hiding this comment.
Suggested change
| wrapQtAppsHook | |
| wrapQtAppsHook |
| @@ -0,0 +1,36 @@ | |||
| { | |||
10 tasks
|
I marked this as stale due to inactivity. → More info |
stale
bot
added
the
2.status: stale
|
Closing in favour of #129246 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
bring back https://github.com/NixOS/nixpkgs/pull/55762/commits from dead
Things done
Copy pasted aanderse's code plus some qt specific changes plus a version bump
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)