Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mkgmap: 4289 -> 4432 #78923

Merged
merged 1 commit into from Jan 31, 2020
Merged

mkgmap: 4289 -> 4432 #78923

merged 1 commit into from Jan 31, 2020

Conversation

sikmir
Copy link
Member

@sikmir sikmir commented Jan 30, 2020

Motivation for this change

http://www.mkgmap.org.uk/download/mkgmap.html

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
$ nix path-info -Sh /nix/store/6gvv7vmasvvj3jlrnls0v0adjj4i05zm-mkgmap-4289
/nix/store/6gvv7vmasvvj3jlrnls0v0adjj4i05zm-mkgmap-4289	391.8M
$ nix path-info -Sh /nix/store/zwigci4m3kpf8n32lgvyv2vadmphipgl-mkgmap-4432
/nix/store/zwigci4m3kpf8n32lgvyv2vadmphipgl-mkgmap-4432	391.8M

jonringer
jonringer approved these changes Jan 31, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
shows usage

[3 built, 21 copied (340.9 MiB), 91.6 MiB DL]
https://github.com/NixOS/nixpkgs/pull/78923
1 package built:
mkgmap

@jonringer jonringer merged commit 7267908 into NixOS:master Jan 31, 2020
@sikmir sikmir deleted the mkgmap branch January 31, 2020 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sikmir @jonringer