Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.sympy: 1.5 -> 1.5.1 #78866

Merged
merged 1 commit into from Jan 30, 2020
Merged

pythonPackages.sympy: 1.5 -> 1.5.1 #78866

merged 1 commit into from Jan 30, 2020

Conversation

drewrisinger
Copy link
Contributor

Motivation for this change

Fix core regressions in 1.5. Changelog: https://github.com/sympy/sympy/wiki/Release-Notes-for-1.5.1

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Cleaned up the meta section a bit

cc @ @timokau @lovek323 @jonringer

@drewrisinger
pythonPackages.sympy: 1.5 -> 1.5.1
5bf67da 
Fixes core regression (compare expressions to strings), and
lambdify using deprecated scipy functions vs numpy functions.
Changelog: https://github.com/sympy/sympy/wiki/Release-Notes-for-1.5.1

No known breaks. Sage should be fine @timokau
timokau
timokau approved these changes Jan 30, 2020
View reviewed changes
Copy link
Member

@timokau timokau left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For future reference:

  • Its nicer to make cleanups in a separate commit from the update.
  • If you ping me in a commit message github will notify me every time you (or probably someone else) push or force-push that commit to a repository. I didn't know that myself yet. Bit of an annoying feature.

Otherwise LGTM and the nitpick isn't important enough to hold back. Thanks a lot!

Edidt: Waiting for ofBorg before merging.

@drewrisinger
Copy link
Contributor Author

@timokau will keep in mind for future. Thanks.
Sorry about the notifications.

@ofborg ofborg bot requested review from timokau and lovek323 January 30, 2020 16:43
@timokau timokau merged commit ff478ea into NixOS:master Jan 30, 2020
anna328p pushed a commit to anna328p/nixpkgs that referenced this pull request Feb 2, 2020
@timokau @anna328p
Merge pull request NixOS#78866 from drewrisinger/dr-pr-sympy-bump
45435f3 
pythonPackages.sympy: 1.5 -> 1.5.1
@drewrisinger drewrisinger deleted the dr-pr-sympy-bump branch February 18, 2020 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@timokau timokau Awaiting requested review from timokau

@lovek323 lovek323 Awaiting requested review from lovek323

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@drewrisinger @timokau