Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zsh: fix bracketed-paste-magic #78819

Merged
merged 1 commit into from
Feb 11, 2020
Merged

zsh: fix bracketed-paste-magic #78819

merged 1 commit into from
Feb 11, 2020
+29 −0

Conversation

Izorkin
Copy link
Contributor

@Izorkin Izorkin commented Jan 30, 2020 •
edited
Loading

Motivation for this change

Fix this error (Used putty/kitty):
bracketed-paste-magic:zle:47: not enough arguments for -U

http://www.zsh.org/mla/workers/2019/msg00808.html

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@ofborg ofborg bot requested a review from pSub January 30, 2020 08:47
pSub
pSub approved these changes Jan 30, 2020
View reviewed changes
Copy link
Member

@pSub pSub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Izorkin
Copy link
Contributor Author

Izorkin commented Jan 30, 2020

Added comment.

@ofborg ofborg bot requested a review from pSub January 30, 2020 12:34
@Ma27 Ma27 self-requested a review February 6, 2020 06:06
Ma27
Ma27 reviewed Feb 11, 2020
View reviewed changes
Copy link
Member

@Ma27 Ma27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Disclaimer: I just happened to observe this as well, but I'm not experienced enough with zsh to give technical feedback).

I managed to reproduce this (ocassionally, but with no actual pattern) with alacritty 0..4.1 (on nixos 19.09), but not with kitty (used the versions 0.15.2 and 0.16.0). Also, when using this fix, I can't copy anything anymore.

@Izorkin
Copy link
Contributor Author

Izorkin commented Feb 11, 2020

On Windows 10 and kitty 0.73.2.2p it works correctly for me

@Mic92 Mic92 merged commit f3d5966 into NixOS:master Feb 11, 2020
@Izorkin
Copy link
Contributor Author

Izorkin commented Feb 11, 2020

Thanks!

@Izorkin Izorkin deleted the zsh-fix branch February 11, 2020 18:50
@Mic92
Copy link
Member

Mic92 commented Feb 11, 2020

backport: 94c380c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92

@Ma27 Ma27

@pSub pSub

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Izorkin @Mic92 @pSub @Ma27