gettext: Add macOS warning patch #78820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
10.rebuild-darwin: 501+
10.rebuild-darwin: 5001+
10.rebuild-linux: 0
labels
zimbatm
reviewed
Jan 30, 2020
|
Nice! Needs to target the staging branch, though. |
kirelagin
force-pushed
the
macos-gettext-warn
branch
from
2785981
to
f920f8d
Compare
gettext 0.20 fixed a bug with handling locale on macOS, but this caused it to report an annoying warning on systems where “language” differs from “region”. See Homebrew issue for details: <Homebrew/homebrew-core#41139>. Add upstream patch that has not been released yet. Details: <https://www.mail-archive.com/bug-gnulib@gnu.org/msg36768.html>.
kirelagin
force-pushed
the
macos-gettext-warn
branch
from
f920f8d
to
d9e4fc3
Compare
|
Done and done. |
veprbl
approved these changes
Jan 31, 2020
There was a problem hiding this comment.
Works as intended:
[nix-shell:~/.cache/nix-review/pr-78820-1/nixpkgs]$ git checkout refs/nix-review/0
Previous HEAD position was d9e4fc31ea7 gettext: Add macOS warning patch
HEAD is now at 16ffc74a323 Merge pull request #71557 from r-ryantm/auto-update/enchant
[nix-shell:~/.cache/nix-review/pr-78820-1/nixpkgs]$ LC_ALL=en_RU.UTF-8 nix-shell -Q -I nixpkgs=`pwd` -p wget --run wget
bash: warning: setlocale: LC_ALL: cannot change locale (en_RU.UTF-8): No such file or directory
Warning: Failed to set locale category LC_NUMERIC to en_RU.UTF-8.
Warning: Failed to set locale category LC_TIME to en_RU.UTF-8.
Warning: Failed to set locale category LC_COLLATE to en_RU.UTF-8.
Warning: Failed to set locale category LC_MONETARY to en_RU.UTF-8.
Warning: Failed to set locale category LC_MESSAGES to en_RU.UTF-8.
wget: missing URL
Usage: wget [OPTION]... [URL]...
Try `wget --help' for more options.
[nix-shell:~/.cache/nix-review/pr-78820-1/nixpkgs]$ git checkout refs/nix-review/1
Previous HEAD position was 16ffc74a323 Merge pull request #71557 from r-ryantm/auto-update/enchant
HEAD is now at d9e4fc31ea7 gettext: Add macOS warning patch
[nix-shell:~/.cache/nix-review/pr-78820-1/nixpkgs]$ LC_ALL=en_RU.UTF-8 nix-shell -Q -I nixpkgs=`pwd` -p wget --run wget
bash: warning: setlocale: LC_ALL: cannot change locale (en_RU.UTF-8): No such file or directory
wget: missing URL
Usage: wget [OPTION]... [URL]...
Try `wget --help' for more options.
LnL7
reviewed
Jan 31, 2020
|
Feel free to squash and merge or drop the last commit and merge, as you see fit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gettext 0.20 fixed a bug with handling locale on macOS, but this caused
it to report an annoying warning on systems where “language”
differs from “region”. See Homebrew issue for details:
Homebrew/homebrew-core#41139.
Add upstream patch that has not been released yet.
Details:
https://www.mail-archive.com/bug-gnulib@gnu.org/msg36768.html.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)