Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubernetes-helm: 3.0.1 -> 3.0.3 and improve build meta #78796

Merged
merged 2 commits into from Feb 1, 2020
Merged

kubernetes-helm: 3.0.1 -> 3.0.3 and improve build meta #78796

merged 2 commits into from Feb 1, 2020

Conversation

Frostman
Copy link
Member

@Frostman Frostman commented Jan 30, 2020 •
edited

Motivation for this change

Update K8s Helm to the latest version. Both 3.0.2 and 3.0.3 are patch releases with some important fixes. Additionally, I'd like to add myself to maintainers as I'm using it quite extensively and can help to keep its package up to date and supported.

https://github.com/helm/helm/releases/tag/v3.0.2
https://github.com/helm/helm/releases/tag/v3.0.3

Fix to ldflags is needed to get correct helm version output:

$ helm version
version.BuildInfo{Version:"v3.0.3", GitCommit:"", GitTreeState:"", GoVersion:"go1.13.6"}
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

This change is Reviewable

saschagrunert
saschagrunert approved these changes Jan 30, 2020
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

edude03
edude03 approved these changes Jan 30, 2020
View reviewed changes
Copy link
Contributor

@edude03 edude03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 looks good to me

@kalbasit
Copy link
Member

@GrahamcOfBorg build helm

@kalbasit
Copy link
Member

The package is actually called kubernetes-helm so the PR title/commit must be updated to reflect that.

@GrahamcOfBorg build kubernetes-helm

@Frostman Frostman changed the title helm: 3.0.1 -> 3.0.3 and improve build meta kubernetes-helm: 3.0.1 -> 3.0.3 and improve build meta Jan 30, 2020
@Frostman
Copy link
Member Author

@kalbasit thx for the review. Fixed title and dropped goPackagePath from legacy go support.

@kalbasit
Copy link
Member

@Frostman looks good. Do you mind updating the commit message of e25233cd23f0c73a0e4b7d934bff19c13afe993f as well.

@Frostman
Copy link
Member Author

Frostman commented Feb 1, 2020

@kalbasit done, thx for reviews

@ofborg ofborg bot requested a review from saschagrunert February 1, 2020 06:05
@kalbasit
Copy link
Member

kalbasit commented Feb 1, 2020

@GrahamcOfBorg build kubernetes-helm

@kalbasit kalbasit merged commit 65e6812 into NixOS:master Feb 1, 2020
@Frostman Frostman deleted the helm-3.0.3 branch February 1, 2020 18:10
anna328p pushed a commit to anna328p/nixpkgs that referenced this pull request Feb 2, 2020
@kalbasit @anna328p
Merge pull request NixOS#78796 from Frostman/helm-3.0.3
7e821ad 
kubernetes-helm: 3.0.1 -> 3.0.3 and improve build meta
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalbasit kalbasit kalbasit approved these changes

@rlupton20 rlupton20 Awaiting requested review from rlupton20

@edude03 edude03 Awaiting requested review from edude03

@saschagrunert saschagrunert Awaiting requested review from saschagrunert

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Frostman @kalbasit @edude03 @saschagrunert