Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

silicon: init at 0.3.0 #78795

Merged
merged 1 commit into from Jan 31, 2020
Merged

silicon: init at 0.3.0 #78795

merged 1 commit into from Jan 31, 2020

Conversation

evanjs
Copy link
Member

@evanjs evanjs commented Jan 30, 2020

Motivation for this change

Silicon is similar to carbon, but works offline, and even supports the Nix expression language.

cat nixpkgs/pkgs/tools/misc/silicon/default.nix | silicon -l nix --output /tmp/silicon.nix.png

silicon nix

Things done

Can anybody confirm whether this works on Darwin?

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@evanjs evanjs requested a review from marsam January 31, 2020 00:44
@marsam
Copy link
Contributor

marsam commented Jan 31, 2020 •
edited

Thank you. I made minor cosmetic fixes and added support for darwin, I hope you don't mind

@marsam marsam merged commit f36cf56 into NixOS:master Jan 31, 2020
anna328p pushed a commit to anna328p/nixpkgs that referenced this pull request Feb 2, 2020
@marsam @anna328p
Merge pull request NixOS#78795 from evanjs/silicon-init
6e8c450 
silicon: init at 0.3.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marsam marsam Awaiting requested review from marsam

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@evanjs @marsam