Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x264: fix on ARM #78846

Merged
merged 2 commits into from Jan 30, 2020
Merged

x264: fix on ARM #78846

merged 2 commits into from Jan 30, 2020

Conversation

worldofpeace
Copy link
Contributor

Motivation for this change

This has broken a lot of stuff on aarch64-linux.
I believe it was broken in 2e5051e

Yes this is culted from https://github.com/void-linux/void-packages/blob/master/srcpkgs/x264/template

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace worldofpeace mentioned this pull request Jan 30, 2020
Merged
10 tasks
@ofborg ofborg bot requested review from spwhitt and tadeokondrak January 30, 2020 13:35
@Ma27
Copy link
Member

Ma27 commented Jan 30, 2020

Hmm... would it make sense to merge this to staging instead?

@worldofpeace worldofpeace changed the base branch from master to staging January 30, 2020 14:01
@worldofpeace worldofpeace merged commit 49f13ce into NixOS:staging Jan 30, 2020
@worldofpeace
Copy link
Contributor Author

Hmm... would it make sense to merge this to staging instead?

Done 👍

@worldofpeace worldofpeace deleted the x264-aarch64-fix branch January 30, 2020 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tadeokondrak tadeokondrak tadeokondrak approved these changes

@Ma27 Ma27 Ma27 approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 101-500 10.rebuild-linux: 501-1000 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@worldofpeace @Ma27 @tadeokondrak