Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

php: 7.2.28 -> 7.2.29, 7.3.15 -> 7.3.16, 7.4.3 -> 7.4.4 #84389

Merged
merged 3 commits into from Apr 6, 2020
Merged

php: 7.2.28 -> 7.2.29, 7.3.15 -> 7.3.16, 7.4.3 -> 7.4.4 #84389

merged 3 commits into from Apr 6, 2020

Conversation

etu
Copy link
Contributor

@etu etu commented Apr 5, 2020 •
edited

Motivation for this change

Normal package version updates.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@etu etu added the 9.needs: port to stable A PR needs a backport to the stable release. label Apr 5, 2020
@ofborg ofborg bot requested review from globin and Ma27 April 5, 2020 20:16
@etu
Copy link
Contributor Author

etu commented Apr 5, 2020

@GrahamcOfBorg build php72 php73 php74 nixosTests.php nixosTests.nextcloud

Ma27
Ma27 approved these changes Apr 5, 2020
View reviewed changes
Copy link
Member

@Ma27 Ma27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds fine locally and seems fine 👍

@Ma27 Ma27 merged commit de08394 into NixOS:master Apr 6, 2020
@Ma27
Copy link
Member

Ma27 commented Apr 6, 2020

Currently preparing the backport :)

@etu
Copy link
Contributor Author

etu commented Apr 6, 2020

Currently preparing the backport :)

I hope it doesn't conflict too badly, because if it does it will continue doing so for the next 6 months :D

@etu etu deleted the php-updates branch April 6, 2020 16:24
@Ma27
Copy link
Member

Ma27 commented Apr 6, 2020

Backported as 865abba, 185b684, 84926c9

I hope it doesn't conflict too badly, because if it does it will continue doing so for the next 6 months :D

Wasn't too bad IMHO :)

@Ma27 Ma27 added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Apr 6, 2020
@etu
Copy link
Contributor Author

etu commented Apr 6, 2020

But they probably didn't cleanly apply, so probably needed some touches... :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ma27 Ma27 Ma27 approved these changes

@globin globin Awaiting requested review from globin globin is a code owner

Assignees
No one assigned
Labels
8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@etu @Ma27