Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

facetimehd: update src to build with linux >= 5.6 #84387

Merged
merged 1 commit into from Apr 5, 2020

Conversation

kraem
Copy link
Member

@kraem kraem commented Apr 5, 2020

Motivation for this change

When building facetimehd with Linux > 5.6 I'm getting this error

  /nix/store/mal5kzg5h23mha321kj59ai9ckz7ldvr-nixos-system-frigate-20.09pre-git.drv
building '/nix/store/dyr4pvy1kh8j3wi652kmzxipppmr3pcp-facetimehd-unstable-2019-12-10-5.6.2.drv'...
unpacking sources
unpacking source archive /nix/store/n4bm3asc6360z7ba4ip7257czwg677hl-source
source root is source
patching sources
configuring
no configure script, doing nothing
building
build flags: SHELL=/nix/store/z4ajipns0l1s8b2lrgpy6nng4cys7h99-bash-4.4-p23/bin/bash KDIR=/nix/store/hz13cyz8nkyjpyfszppyhf0idiszyj91-linux-5.6.2-dev/lib/modules/5.6.2/build
make -C /nix/store/hz13cyz8nkyjpyfszppyhf0idiszyj91-linux-5.6.2-dev/lib/modules/5.6.2/build M=/build/source modules
make[1]: Entering directory '/nix/store/hz13cyz8nkyjpyfszppyhf0idiszyj91-linux-5.6.2-dev/lib/modules/5.6.2/build'
  CC [M]  /build/source/fthd_ddr.o
  CC [M]  /build/source/fthd_hw.o
  CC [M]  /build/source/fthd_drv.o
/build/source/fthd_drv.c: In function 'fthd_pci_reserve_mem':
/build/source/fthd_drv.c:73:20: error: implicit declaration of function 'ioremap_nocache'; did you mean 'ioremap_cache'? [-Werror=implicit-function-declaration]
   73 |  dev_priv->s2_io = ioremap_nocache(start, len);
      |                    ^~~~~~~~~~~~~~~
      |                    ioremap_cache
Things done

Successfully built with #84303

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@grahamc grahamc merged commit 65d3a18 into NixOS:master Apr 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants