Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AdGuardHome: init at 0.101.0 #84386

Merged
merged 1 commit into from Jun 17, 2020
Merged

AdGuardHome: init at 0.101.0 #84386

merged 1 commit into from Jun 17, 2020

Conversation

numkem
Copy link
Contributor

@numkem numkem commented Apr 5, 2020

Motivation for this change

Package is missing. Built using the binary release from GitHub. While not ideal, I couldn't figure out how to build the app using node2nix and stdenv since this app has a Go backend but a JS frontend that needs to be built using npm.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@numkem
Copy link
Contributor Author

numkem commented Apr 5, 2020

#84286 has my commit for the maintainer change.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/138

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/155

@Lassulus Lassulus merged commit 0dacf1d into NixOS:master Jun 17, 2020
@numkem numkem deleted the adguardhome branch June 18, 2020 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants