Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mongodb: 4.0.12 -> 4.2.5 #84320

Closed
wants to merge 2 commits into from
Closed

mongodb: 4.0.12 -> 4.2.5 #84320

wants to merge 2 commits into from

Conversation

kfiz
Copy link

@kfiz kfiz commented Apr 5, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

FRidh
FRidh requested changes Apr 5, 2020
View reviewed changes
Copy link
Member

@FRidh FRidh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why two Python 3 scons versions? I don't think we should do that. Have only one. I also suggest splitting the whole scons change into a separate PR.

pkgs/development/python-modules/cheetah3/default.nix
pname = "cheetah3";
version = "3.2.4";

src = fetchurl {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fetchPypi

please read the Python section from the Nixpkgs manual

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't seem to get the package via fetchPypi. Not sure as to what is the reason for that. fetchPypi tries the domains files.pythonhosted.org and pypi.io and fails with both.

pkgs/development/python-modules/psutil/default.nix Outdated
@@ -16,7 +16,7 @@ buildPythonPackage rec {

# arch doesn't report frequency is the same way
# tests segfaults on darwin https://github.com/giampaolo/psutil/issues/1715
doCheck = stdenv.isDarwin || stdenv.isx86_64;
doCheck = if stdenv.isDarwin then false else stdenv.isx86_64;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why disable tests?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For psutil tests don't work on darwin see: #82524

@kfiz
Copy link
Author

kfiz commented Apr 5, 2020 •
edited

Why two Python 3 scons versions? I don't think we should do that. Have only one. I also suggest splitting the whole scons change into a separate PR.

mongodb 4.2 seems to need a scons version that was built by a python3 interpreter. The current version seems to be built by python 2.7, see https://github.com/NixOS/nixpkgs/blob/9ec439e009098b3132848c525a033a602f74faed/pkgs/development/tools/build-managers/scons/common.nix

I can split that into a separate PR, no problem.

FRidh
FRidh reviewed Apr 5, 2020
View reviewed changes
pkgs/development/tools/build-managers/scons3/setup-hook.sh Outdated
@@ -0,0 +1,84 @@
sconsBuildPhase() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this a copy of the existing setup hook?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes.

primeos
primeos previously requested changes Apr 5, 2020
View reviewed changes
Copy link
Member

@primeos primeos left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding SCons: That change for Python 3 shouldn't be required anymore as we finally merged #75877 which is now also in master. After a rebase you should be able to drop these SCons changes.

@grahamc
Copy link
Member

grahamc commented Apr 6, 2020

@GrahamcOfBorg eval

@adrian-gierakowski
Copy link
Contributor

Anything specific blocking this PR? Would be nice to have it merged.

As a side note: would it be possible to get mongodb to be built by hydra and included in binary chance again? Even though the licence is not officially recognised as “free” by FSF there is nothing in it that should detract from building and redistributing the binary.

@primeos primeos dismissed their stale review July 10, 2020 17:34

Outdated (fixed)

@kfiz
Copy link
Author

kfiz commented Jul 28, 2020

I think we can close this. @pjjw bumped this to 4.2.8, which was merged 3 days ago.
See dbd0f3e

@jonringer
Copy link
Contributor

@kfiz thanks for opening a PR, sorry it seems that your efforts were shadowed by another commit.

But I agree that this should probably be closed now that there's a newer version on master

@jonringer jonringer closed this Aug 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh FRidh requested changes

@primeos primeos primeos left review comments

@jonringer jonringer Awaiting requested review from jonringer

@cstrahan cstrahan Awaiting requested review from cstrahan

@offlinehacker offlinehacker Awaiting requested review from offlinehacker

@bluescreen303 bluescreen303 Awaiting requested review from bluescreen303

Assignees
No one assigned
Labels
2.status: work-in-progress 6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@kfiz @grahamc @adrian-gierakowski @jonringer @FRidh @primeos