Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #8064: Incorrect display of refit capacity #8065

Merged
merged 1 commit into from Apr 6, 2020
Merged

Fix #8064: Incorrect display of refit capacity #8065

merged 1 commit into from Apr 6, 2020

Conversation

glx22
Copy link
Contributor

@glx22 glx22 commented Apr 6, 2020

_returned_refit_capacity was too small to contain the total capacity

OpenTTD/src/vehicle_cmd.cpp

Line 448 in 7fe2916

_returned_refit_capacity = total_capacity;

Also increased TestedEngineDetails::capacity for this reason

OpenTTD/src/build_vehicle_gui.cpp

Line 1222 in 7fe2916

this->te.capacity = _returned_refit_capacity;

Then GetArticulatedVehicleCargoesAndRefits() signature required an update too.

LordAro
LordAro approved these changes Apr 6, 2020
View reviewed changes
Copy link
Member

@LordAro LordAro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Purely a display issue? Works nicely for me :)

@LordAro LordAro added the backport requested This PR should be backport to current release (RC / stable) label Apr 6, 2020
@glx22
Copy link
Contributor Author

glx22 commented Apr 6, 2020 •
edited

Well AI also use this value to get refit capacity, so now they'll get the right value :)
Anyway it's very rare for an engine to have these high capacities.

@LordAro LordAro merged commit b50d77b into OpenTTD:master Apr 6, 2020
@glx22 glx22 deleted the fix_8064 branch April 6, 2020 15:39
@LordAro LordAro added backported This PR is backported to a current release (RC / stable) and removed backport requested This PR should be backport to current release (RC / stable) labels Apr 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LordAro LordAro LordAro approved these changes

Assignees
No one assigned
Labels
backported This PR is backported to a current release (RC / stable)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@glx22 @LordAro