bash-completion: 2.9 -> 2.10 #84485
Merged
bash-completion: 2.9 -> 2.10 #84485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems like gcc completions assume x86 CPU. |
KamilaBorowska
force-pushed
the
bash-completion-update
branch
2 times, most recently
from
a0457c4
to
c187bb2
Compare
|
@GrahamcOfBorg build bash-completion |
|
Chances are this is broken on macOS, and this is an important package, can somebody run this on Darwin? |
KamilaBorowska
force-pushed
the
bash-completion-update
branch
from
c187bb2
to
36c50a3
Compare
|
@GrahamcOfBorg build bash-completion |
KamilaBorowska
force-pushed
the
bash-completion-update
branch
from
36c50a3
to
c5d79de
Compare
|
stdenv for darwin on staging is broken, okay then... Rebased newest staging, but I'm not sure if it's going to help with anything. Oh well, if Darwin is broken, it likely doesn't block this package update. |
|
@GrahamcOfBorg build bash-completion |
jtojnar
force-pushed
the
bash-completion-update
branch
from
c5d79de
to
bdb2bed
Compare
ofborg
bot
added
the
6.topic: GNOME
|
Thanks. Also pushed GNOME Shell fix, which would have been broken by this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Getting pytest 5.4 to work step-by-step.
Things done
Tested using sandboxing (nix.useSandbox on NixOS, or option
sandboxinnix.confon non-NixOS linux)Built on platform(s)
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using
nix-shell -p nixpkgs-review --run "nixpkgs-review wip"Tested execution of all binary files (usually in
./result/bin/)Determined the impact on package closure size (by running
nix path-info -Sbefore and after)Ensured that relevant documentation is up to date
Fits CONTRIBUTING.md.
Also, I tested whether this works with
unset BASH_COMPLETION_VERSINFO; . result/etc/profile.d/bash_completion.shin nix-shell. I'm pretty sure I could have done it in a smarter way, but at the very least, it has shown that unzip supports files withaabextension which was introduced in 2.10 (see https://github.com/scop/bash-completion/blob/master/CHANGES).